Bug#960639: src:orthanc-imagej: Please add support to build against libjson-simple-java >= 3

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#960639: src:orthanc-imagej: Please add support to build against libjson-simple-java >= 3

Gilles Filippini-2
Package: src:orthanc-imagej
Version: 1.2+dfsg-1
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

I'd like to transition json-simple 3.1.1 to unstable, but orthanc-imagej is a blocker since it builds against libjson-simple-java << 3 only.

The json-simple classes used by orthanc-imagej were deprecated in version 2.0.0 [1]. There were removed in versions 3.x [2].

[1] https://github.com/cliftonlabs/json-simple/blob/json-simple-2.0.0/README.txt
[2] https://github.com/cliftonlabs/json-simple/blob/json-simple-3.0.1/CHANGELOG

Please find attached a patch proposal to use the current json-simple classes. I've tested that the package builds correctly against libjson-simple-java version 2.3.0-1 from unstable and version 3.1.1-1~exp2 currently in experimental. But I don't known how to test the package afterward.

Thanks in advance for considering.

_g.

- -- System Information:
Debian Release: buster/sid
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEoJObzArDE05WtIyR7+hsbH/+z4MFAl69xOcACgkQ7+hsbH/+
z4M05QgArerRja+IdHaKJdRugPYsdrg7UkATnA6+fdfZqZ556z0PEfspvQBMDUIO
fCUymwo0IozDmxNq5COn2w0AbExgwOTwsnf/Pg3t0xGw0AjdBsckvqS0P1H9APWz
m/uZHlFA8TZ2V1SPtoRK4HnE8Ru8K0ho1yexl1jSPenLFFaAWpPJK1Vib/M+2c+3
DKIjQQ2gW2g2N4+IHkinKW5KLuYr+4AErPNRP7VdVAxUcplYk1WpfRcbyMDhogTF
ZGK35Bew9eXc71Wg3WNPZSwM/RnD/sgx0MMeknOeJxtFgMt3CyoKWtWIALMuNq62
S0omjztsZNfsU6LcS+cUMvPLRteAOA==
=UUGZ
-----END PGP SIGNATURE-----

orthanc-imagej-json-simple.debdiff (18K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Bug#960639: [Debian-med-packaging] Bug#960639: src:orthanc-imagej: Please add support to build against libjson-simple-java >= 3

Sébastien Jodogne-2
Hello,

I thank you much for your patch.

As far as I'm concerned, I don't have time to have a look at this
problem in the upstream project before several months. The Orthanc
project is indeed under heavy pressure because of the COVID crisis, and
ImageJ support is not urgent in this context.

Regarding Debian packaging, I'm currently focused on the C++ packages
related to Orthanc, which doesn't include the "orthanc-imagej" package
(Java).

I suggest thus two possibilities:

(1) Someone else integrates Gilles' patch, or

(2) orthanc-imagej is temporarily removed from unstable.

As written above, unfortunately, I won't have a look at these two
possibilities by myself right now. Any help from another Debian
maintainer is thus welcome, feel free to take care of the
"orthanc-imagej" package.

Kind Regards,
Sébastien-


On 15/05/20 00:23, Gilles Filippini wrote:

> Package: src:orthanc-imagej
> Version: 1.2+dfsg-1
> Severity: normal
> Tags: patch
>
> Hi,
>
> I'd like to transition json-simple 3.1.1 to unstable, but orthanc-imagej is a blocker since it builds against libjson-simple-java << 3 only.
>
> The json-simple classes used by orthanc-imagej were deprecated in version 2.0.0 [1]. There were removed in versions 3.x [2].
>
> [1] https://github.com/cliftonlabs/json-simple/blob/json-simple-2.0.0/README.txt
> [2] https://github.com/cliftonlabs/json-simple/blob/json-simple-3.0.1/CHANGELOG
>
> Please find attached a patch proposal to use the current json-simple classes. I've tested that the package builds correctly against libjson-simple-java version 2.3.0-1 from unstable and version 3.1.1-1~exp2 currently in experimental. But I don't known how to test the package afterward.
>
> Thanks in advance for considering.
>
> _g.
>
> -- System Information:
> Debian Release: buster/sid
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
>
> Kernel: Linux 5.6.0-1-amd64 (SMP w/4 CPU cores)
> Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
>
>
>
> _______________________________________________
> Debian-med-packaging mailing list
> [hidden email]
>
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging
>

--
Sébastien Jodogne
Mail: [hidden email]
Web: http://www.orthanc-labs.com/
Twitter: https://twitter.com/sjodogne

Reply | Threaded
Open this post in threaded view
|

Bug#960639: Bug#960639: src:orthanc-imagej: Please add support to build against libjson-simple-java >= 3

Andreas Tille-5
Hi Sébastien,

On Fri, May 15, 2020 at 07:50:01AM +0200, Sébastien Jodogne wrote:
> As far as I'm concerned, I don't have time to have a look at this
> problem in the upstream project before several months. The Orthanc
> project is indeed under heavy pressure because of the COVID crisis, and
> ImageJ support is not urgent in this context.

Thank you for your work on Orthanc upstream and in Debian.
 
> Regarding Debian packaging, I'm currently focused on the C++ packages
> related to Orthanc, which doesn't include the "orthanc-imagej" package
> (Java).
>
> I suggest thus two possibilities:
>
> (1) Someone else integrates Gilles' patch, or

Gilles, would you mind just doing a team upload?
 
> (2) orthanc-imagej is temporarily removed from unstable.

I do not se any relevance for this since the bug is not RC.

> As written above, unfortunately, I won't have a look at these two
> possibilities by myself right now. Any help from another Debian
> maintainer is thus welcome, feel free to take care of the
> "orthanc-imagej" package.

Gilles, please let us know if this is urgent and you do not
feel comfortable with doing it yourself.

Kind regards

      Andreas.
 

> On 15/05/20 00:23, Gilles Filippini wrote:
> > Package: src:orthanc-imagej
> > Version: 1.2+dfsg-1
> > Severity: normal
> > Tags: patch
> >
> > Hi,
> >
> > I'd like to transition json-simple 3.1.1 to unstable, but orthanc-imagej is a blocker since it builds against libjson-simple-java << 3 only.
> >
> > The json-simple classes used by orthanc-imagej were deprecated in version 2.0.0 [1]. There were removed in versions 3.x [2].
> >
> > [1] https://github.com/cliftonlabs/json-simple/blob/json-simple-2.0.0/README.txt
> > [2] https://github.com/cliftonlabs/json-simple/blob/json-simple-3.0.1/CHANGELOG
> >
> > Please find attached a patch proposal to use the current json-simple classes. I've tested that the package builds correctly against libjson-simple-java version 2.3.0-1 from unstable and version 3.1.1-1~exp2 currently in experimental. But I don't known how to test the package afterward.
> >
> > Thanks in advance for considering.
> >
> > _g.
> >
> > -- System Information:
> > Debian Release: buster/sid
> > Architecture: amd64 (x86_64)
> > Foreign Architectures: i386
> >
> > Kernel: Linux 5.6.0-1-amd64 (SMP w/4 CPU cores)
> > Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
> > Shell: /bin/sh linked to /bin/dash
> > Init: systemd (via /run/systemd/system)
> > LSM: AppArmor: enabled
> >
> >
> >
> > _______________________________________________
> > Debian-med-packaging mailing list
> > [hidden email]
> >
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging
> >
>
> --
> Sébastien Jodogne
> Mail: [hidden email]
> Web: http://www.orthanc-labs.com/
> Twitter: https://twitter.com/sjodogne
>
> _______________________________________________
> Debian-med-packaging mailing list
> [hidden email]
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging

--
http://fam-tille.de

Reply | Threaded
Open this post in threaded view
|

Bug#960639: Bug#960639: src:orthanc-imagej: Please add support to build against libjson-simple-java >= 3

Gilles Filippini-2
Andreas Tille a écrit le 15/05/2020 à 12:49 :

> Hi Sébastien,
>
> On Fri, May 15, 2020 at 07:50:01AM +0200, Sébastien Jodogne wrote:
>> As far as I'm concerned, I don't have time to have a look at this
>> problem in the upstream project before several months. The Orthanc
>> project is indeed under heavy pressure because of the COVID crisis, and
>> ImageJ support is not urgent in this context.
>
> Thank you for your work on Orthanc upstream and in Debian.
>  
>> Regarding Debian packaging, I'm currently focused on the C++ packages
>> related to Orthanc, which doesn't include the "orthanc-imagej" package
>> (Java).
>>
>> I suggest thus two possibilities:
>>
>> (1) Someone else integrates Gilles' patch, or
>
> Gilles, would you mind just doing a team upload?
>  
>> (2) orthanc-imagej is temporarily removed from unstable.
>
> I do not se any relevance for this since the bug is not RC.
>
>> As written above, unfortunately, I won't have a look at these two
>> possibilities by myself right now. Any help from another Debian
>> maintainer is thus welcome, feel free to take care of the
>> "orthanc-imagej" package.
>
> Gilles, please let us know if this is urgent and you do not
> feel comfortable with doing it yourself.

It's not a problem doing the upload. this is the easy part :)
What I'm uncomfortable with is that I don't know how to test whether my
patch is correct. Is there any test suite or sample case available?

Thanks,

_g.

Reply | Threaded
Open this post in threaded view
|

Bug#960639: Bug#960639: src:orthanc-imagej: Please add support to build against libjson-simple-java >= 3

Sébastien Jodogne-2
Dear Gilles,

I finally managed to find a few hours to finalize your patch. I had to
extend it a bit so for it to work correctly [1].

Version "1.2+dfsg-2" of the package has just been uploaded accordingly.

> It's not a problem doing the upload. this is the easy part :)
> What I'm uncomfortable with is that I don't know how to test whether my
> patch is correct. Is there any test suite or sample case available?

Regarding the testing of the package, I only do a few smoke tests.

They consist in (a) installing the "orthanc" package, then (b) uploading
a few DICOM files (some sample files are e.g. available in the
integration tests of Orthanc [2]), and finally (c) opening imagej and
playing with it as in the demo video [3].

Thanks again for your patch,
Regards,
Sébastien-


[1]
https://salsa.debian.org/med-team/orthanc-imagej/-/commit/99b71334bc8aefb4b92322a3058e144df58fa223
[2] https://hg.orthanc-server.com/orthanc-tests/file/default/Database
[3] https://www.youtube.com/watch?v=wsslVhE-R1Q

Reply | Threaded
Open this post in threaded view
|

Bug#960639: Bug#960639: src:orthanc-imagej: Please add support to build against libjson-simple-java >= 3

Gilles Filippini-2
Sébastien Jodogne a écrit le 28/05/2020 à 11:28 :
> Dear Gilles,
>
> I finally managed to find a few hours to finalize your patch. I had to
> extend it a bit so for it to work correctly [1].
>
> Version "1.2+dfsg-2" of the package has just been uploaded accordingly.

Thanks!!

Best,

_ni.