Bug#961419: r-cran-sjlabelled: autopkgtest failure

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#961419: r-cran-sjlabelled: autopkgtest failure

Adrian Bunk-3
Source: r-cran-sjlabelled
Version: 1.1.4-1
Severity: serious

r-cran-haven was demoted from Depends to Suggests,
which broke the autopkgtest:

https://ci.debian.net/data/autopkgtest/testing/amd64/r/r-cran-sjlabelled/5618427/log.gz

...
> library(testthat)
> library(sjlabelled)
>
> test_check("sjlabelled")
── 1. Error: remove_labels (@test-remove_labels.R#6)  ──────────────────────────
Package 'haven' required for this function. Please install it.
Backtrace:
 1. sjlabelled::remove_labels(z, labels = 2)
 2. sjlabelled:::remove_labels_helper(.dat, labels)
 4. sjlabelled:::get_na.default(x)
 5. sjlabelled:::get_na_helper(x, as.tag)

══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 8 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
...
Reply | Threaded
Open this post in threaded view
|

Processed: Re: [R-pkg-team] Bug#961419: r-cran-sjlabelled: autopkgtest failure

Debian Bug Tracking System
Processing control commands:

> affects -1 + src:r-cran-ggeffects
Bug #961419 [src:r-cran-sjlabelled] r-cran-sjlabelled: autopkgtest failure
Added indication that 961419 affects src:r-cran-ggeffects
> affects -1 + src:r-cran-sjmisc
Bug #961419 [src:r-cran-sjlabelled] r-cran-sjlabelled: autopkgtest failure
Added indication that 961419 affects src:r-cran-sjmisc
> affects -1 + src:r-cran-sjplot
Bug #961419 [src:r-cran-sjlabelled] r-cran-sjlabelled: autopkgtest failure
Added indication that 961419 affects src:r-cran-sjplot

--
961419: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=961419
Debian Bug Tracking System
Contact [hidden email] with problems

Reply | Threaded
Open this post in threaded view
|

Bug#961419: [R-pkg-team] Bug#961419: r-cran-sjlabelled: autopkgtest failure

Graham Inggs-3
In reply to this post by Adrian Bunk-3
Control: affects -1 + src:r-cran-ggeffects
Control: affects -1 + src:r-cran-sjmisc
Control: affects -1 + src:r-cran-sjplot

I think this is also the cause of the autopkgtest failures in
r-cran-ggeffects [1], r-cran-sjmisc [2] and r-cran-sjplot [3].

[1] https://ci.debian.net/packages/r/r-cran-ggeffects/unstable/amd64/
[2] https://ci.debian.net/packages/r/r-cran-sjmisc/unstable/amd64/
[3] https://ci.debian.net/packages/r/r-cran-sjplot/unstable/amd64/

Reply | Threaded
Open this post in threaded view
|

Bug#961419: marked as done (r-cran-sjlabelled: autopkgtest failure)

Debian Bug Tracking System
In reply to this post by Adrian Bunk-3
Your message dated Mon, 25 May 2020 09:04:27 +0000
with message-id <[hidden email]>
and subject line Bug#961419: fixed in r-cran-sjlabelled 1.1.4-3
has caused the Debian Bug report #961419,
regarding r-cran-sjlabelled: autopkgtest failure
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
961419: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=961419
Debian Bug Tracking System
Contact [hidden email] with problems

Source: r-cran-sjlabelled
Version: 1.1.4-1
Severity: serious

r-cran-haven was demoted from Depends to Suggests,
which broke the autopkgtest:

https://ci.debian.net/data/autopkgtest/testing/amd64/r/r-cran-sjlabelled/5618427/log.gz

...
> library(testthat)
> library(sjlabelled)
>
> test_check("sjlabelled")
── 1. Error: remove_labels (@test-remove_labels.R#6)  ──────────────────────────
Package 'haven' required for this function. Please install it.
Backtrace:
 1. sjlabelled::remove_labels(z, labels = 2)
 2. sjlabelled:::remove_labels_helper(.dat, labels)
 4. sjlabelled:::get_na.default(x)
 5. sjlabelled:::get_na_helper(x, as.tag)

══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 8 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
...

Source: r-cran-sjlabelled
Source-Version: 1.1.4-3
Done: =?utf-8?q?Dylan_A=C3=AFssi?= <[hidden email]>

We believe that the bug you reported is fixed in the latest version of
r-cran-sjlabelled, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dylan Aïssi <[hidden email]> (supplier of updated r-cran-sjlabelled package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 25 May 2020 10:21:18 +0200
Source: r-cran-sjlabelled
Architecture: source
Version: 1.1.4-3
Distribution: unstable
Urgency: medium
Maintainer: Debian R Packages Maintainers <[hidden email]>
Changed-By: Dylan Aïssi <[hidden email]>
Closes: 961419
Changes:
 r-cran-sjlabelled (1.1.4-3) unstable; urgency=medium
 .
   * Team upload.
   * Add r-cran-haven to test-deps (Closes: #961419)
Checksums-Sha1:
 41ad090dfd6f95e53a8dcf79025911a3f3250a3e 2143 r-cran-sjlabelled_1.1.4-3.dsc
 33517d443f2910a200ab2b46b957dfbe32c9cc65 2628 r-cran-sjlabelled_1.1.4-3.debian.tar.xz
 e26e419271867ca528e6f9acf3fe479a6725365d 8490 r-cran-sjlabelled_1.1.4-3_amd64.buildinfo
Checksums-Sha256:
 f58483474a522ec13e1d2b182cabf2fcaeca2c15f5941ad7299c0c5023734927 2143 r-cran-sjlabelled_1.1.4-3.dsc
 b4ee1d4c63e2402f792fcd117db22613b737c8c600e6b8220dfabcb2b84999e6 2628 r-cran-sjlabelled_1.1.4-3.debian.tar.xz
 946b7233da93716ba364dd14434af8b22741f219bf4ca9f0e5dc32a5f2e6673f 8490 r-cran-sjlabelled_1.1.4-3_amd64.buildinfo
Files:
 b8641b3339357c086724500e9400564a 2143 gnu-r optional r-cran-sjlabelled_1.1.4-3.dsc
 480265fd25c300083017e5363be18a3c 2628 gnu-r optional r-cran-sjlabelled_1.1.4-3.debian.tar.xz
 936984b3b3db52dfffee1ea1655d19d8 8490 gnu-r optional r-cran-sjlabelled_1.1.4-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmjwHvQbeL0FugTpdYS7xYT4FD1QFAl7LhXoACgkQYS7xYT4F
D1RU/xAAsAWaxe7LY33mHmaG04/EeiscCL87HmjcPaqg3EUFLhDYO2xy28isTOql
izB1oRUwBBGes2RUzIR/E4qBURgR+36SxXSyhOwiTbY8PZAnn7DVk/tEhLboXkp6
/bWU0VI6x4/pib43kD+VVXzJsD7Z4SIS+0h8tbhvlrPXeMg5kRSv0jDNsbcCqVpJ
5nSkgtok4qDH0BPL0jYEdAeqyHZvuLfvqK2nygz+FdmmFguVi/6BNZdNIPrg5S+q
sZvHwTSM4/Ocawmbfm9sz4h8zf3iz5lir6r7md6QByWZFiv0L6SiWiSkavbwWhye
QhvZayqU4N9Pnj58VsdzCoUOWSHa3+Oy36COiNxJV2GBocHKlX2Fv4VTEN89CBof
sMlWG/zxdfA//4dbc1vM/E93SYD6kPRvUlI3U8k1+3NBGAVdyBV1Sa8i3hHz0OqK
tVvWwY60x/amcrbjP6XwfZ1+OJuLOjVTKTw0EizFgUL75etl3zJKLKM1UdzNcq4r
mq85vCxtPPHnQD6pjMu/JG1EnLBiv0dKwbhhjw7NgvM25Yy2A0xS93wMjAb39gTl
a1uqwUPCVrtn5Lh2niAXStp2mVfKyZOmDcFwL3SX59RyH3VVoa96Q2JxTV1wmCHX
N84+bqTJYK59fBJaiaI/+QDFkbzghwBPZO+gg3T1nf6X9pvqPMA=
=4zXK
-----END PGP SIGNATURE-----
Reply | Threaded
Open this post in threaded view
|

Bug#961419: Description file of r-cran-sjlabelled seems to specify wrong depencency from haven (Was: Bug#961498: r-cran-sjplot: missing test dependency on r-cran-haven)

Andreas Tille-5
In reply to this post by Adrian Bunk-3
Hi,

there is a series of build failures connected to missing r-cran-haven.
Formerly r-cran-sjlabelled dependend from r-cran-haven - and IMHO that
should remain that way:

r-cran-sjlabelled(master) $ grep haven R/* | grep -i required
R/as_label.R:        stop("Package 'haven' required for this function. Please install it.")
R/get_na.R:    stop("Package 'haven' required for this function. Please install it.")
R/read.R:    stop("Package 'haven' required for this function. Please install it.")
R/read.R:    stop("Package 'haven' required for this function. Please install it.")
R/read.R:    stop("Package 'haven' required for this function. Please install it.")
R/remove_labels.R:      stop("Package 'haven' required for this function. Please install it.")
R/remove_labels.R:    stop("Package 'haven' required for this function. Please install it.")
R/set_labels.R:          stop("Package 'haven' required for this function. Please install it.")
R/set_na.R:    stop("Package 'haven' required for this function. Please install it.")
R/write.R:    stop("Package 'haven' required for this function. Please install it.")
R/zap_labels.R:    stop("Package 'haven' required for this function. Please install it.")


I think it is just wrong that DESCRIPTION of sjlabelled just

   Suggests: haven (>= 1.1.2)

I don't understand the difference between Depends and Imports in R
DESCRIPTION files but both are translated to Debian Depends - and this
should be used here.

Kind regards

     Andreas.

On Mon, May 25, 2020 at 01:10:10PM +0300, Adrian Bunk wrote:

> Source: r-cran-sjplot
> Version: 2.8.3-2
> Severity: serious
>
> https://ci.debian.net/data/autopkgtest/testing/amd64/r/r-cran-sjplot/5625656/log.gz
>
> ...
> > library(testthat)
> > library(sjPlot)
> >
> > if (length(strsplit(packageDescription("sjPlot")$Version, "\\.")[[1]]) > 3) {
> +   Sys.setenv("RunAllsjPlotTests" = "yes")
> + }
> >
> > test_check("sjPlot")
> ── 1. Error: (unknown) (@test-plot_model_std.R#15)  ────────────────────────────
> Package 'haven' required for this function. Please install it.
> Backtrace:
>  1. sjmisc::to_factor(efc, e42dep, c172code, c161sex)
>  2. sjmisc:::to_fac_helper(.dat[[i]], add.non.labelled, ref.lvl)
>  5. sjlabelled::set_labels(...)
>  6. sjlabelled:::set_labels_helper(...)
>
> ══ testthat results  ═══════════════════════════════════════════════════════════
> [ OK: 2 | SKIPPED: 0 | WARNINGS: 12 | FAILED: 1 ]
> ...
>
>
> r-cran-sjlabelled no longer depends on r-cran-haven.
> _______________________________________________
> R-pkg-team mailing list
> [hidden email]
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/r-pkg-team

--
http://fam-tille.de

Reply | Threaded
Open this post in threaded view
|

Bug#961419: AW: Description file of r-cran-sjlabelled seems to specify wrong depencency from haven (Was: Bug#961498: r-cran-sjplot: missing test dependency on r-cran-haven)

Daniel Lüdecke
Suggesting the package 'haven' is correct, because it's only used conditionally now. That change was intentional, to reduce package dependencies. See also current sjlablled on CRAN (https://cran.r-project.org/web/packages/sjlabelled/index.html).

Best
Daniel

-----Ursprüngliche Nachricht-----
Von: Andreas Tille [mailto:[hidden email]]
Gesendet: Montag, 25. Mai 2020 13:10
An: Adrian Bunk <[hidden email]>; [hidden email]; [hidden email]; [hidden email]; Daniel Lüdecke <[hidden email]>
Betreff: Description file of r-cran-sjlabelled seems to specify wrong depencency from haven (Was: Bug#961498: r-cran-sjplot: missing test dependency on r-cran-haven)

Hi,

there is a series of build failures connected to missing r-cran-haven.
Formerly r-cran-sjlabelled dependend from r-cran-haven - and IMHO that should remain that way:

r-cran-sjlabelled(master) $ grep haven R/* | grep -i required
R/as_label.R:        stop("Package 'haven' required for this function. Please install it.")
R/get_na.R:    stop("Package 'haven' required for this function. Please install it.")
R/read.R:    stop("Package 'haven' required for this function. Please install it.")
R/read.R:    stop("Package 'haven' required for this function. Please install it.")
R/read.R:    stop("Package 'haven' required for this function. Please install it.")
R/remove_labels.R:      stop("Package 'haven' required for this function. Please install it.")
R/remove_labels.R:    stop("Package 'haven' required for this function. Please install it.")
R/set_labels.R:          stop("Package 'haven' required for this function. Please install it.")
R/set_na.R:    stop("Package 'haven' required for this function. Please install it.")
R/write.R:    stop("Package 'haven' required for this function. Please install it.")
R/zap_labels.R:    stop("Package 'haven' required for this function. Please install it.")


I think it is just wrong that DESCRIPTION of sjlabelled just

   Suggests: haven (>= 1.1.2)

I don't understand the difference between Depends and Imports in R DESCRIPTION files but both are translated to Debian Depends - and this should be used here.

Kind regards

     Andreas.

On Mon, May 25, 2020 at 01:10:10PM +0300, Adrian Bunk wrote:

> Source: r-cran-sjplot
> Version: 2.8.3-2
> Severity: serious
>
> https://ci.debian.net/data/autopkgtest/testing/amd64/r/r-cran-sjplot/5
> 625656/log.gz
>
> ...
> > library(testthat)
> > library(sjPlot)
> >
> > if (length(strsplit(packageDescription("sjPlot")$Version,
> > "\\.")[[1]]) > 3) {
> +   Sys.setenv("RunAllsjPlotTests" = "yes") }
> >
> > test_check("sjPlot")
> ── 1. Error: (unknown) (@test-plot_model_std.R#15)  
> ──────────────────────────── Package 'haven' required for this function. Please install it.
> Backtrace:
>  1. sjmisc::to_factor(efc, e42dep, c172code, c161sex)  2.
> sjmisc:::to_fac_helper(.dat[[i]], add.non.labelled, ref.lvl)  5.
> sjlabelled::set_labels(...)  6. sjlabelled:::set_labels_helper(...)
>
> ══ testthat results  
> ═══════════════════════════════════════════════════════════
> [ OK: 2 | SKIPPED: 0 | WARNINGS: 12 | FAILED: 1 ] ...
>
>
> r-cran-sjlabelled no longer depends on r-cran-haven.
> _______________________________________________
> R-pkg-team mailing list
> [hidden email]
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/r-pkg-team

--
http://fam-tille.de

--

_____________________________________________________________________

Universitätsklinikum Hamburg-Eppendorf; Körperschaft des öffentlichen Rechts; Gerichtsstand: Hamburg | www.uke.de
Vorstandsmitglieder: Prof. Dr. Burkhard Göke (Vorsitzender), Joachim Prölß, Prof. Dr. Blanche Schwappach-Pignataro, Marya Verdel
_____________________________________________________________________

SAVE PAPER - THINK BEFORE PRINTING