Bug#961499: r-cran-sjmisc: missing test dependency on r-cran-haven

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug#961499: r-cran-sjmisc: missing test dependency on r-cran-haven

Adrian Bunk-3
Source: r-cran-sjmisc
Version: 2.8.4-2
Severity: serious

https://ci.debian.net/data/autopkgtest/testing/amd64/r/r-cran-sjmisc/5633123/log.gz

...
── 1. Error: (unknown) (@test-frq_whitespace.R#10)  ────────────────────────────
Package 'haven' required for this function. Please install it.
Backtrace:
 1. sjmisc::rec(dat, y.char, suffix = "_r", as.num = TRUE, rec = "Category1 = 1 [Label 1]; Category2 = 2 [Label 2]; Category3 = 3 [Label 3];")
 2. sjmisc:::rec.default(...)
 3. sjmisc:::rec_core_fun(...)
 4. sjmisc:::rec_helper(...)
 7. sjlabelled::set_labels(x = new_var, labels = val_lab)
 8. sjlabelled:::set_labels_helper(...)
...


r-cran-sjlabelled no longer depends on r-cran-haven.
Reply | Threaded
Open this post in threaded view
|

Bug#961499: [RFS] r-cran-sjplot and r-cran-sjmisc

Andreas Tille-5
Hi Nilesh,

same as for r-cran-sjplot:  In commit d2c969cc you move a file out of
help system to doc and I'm not convinced that this is not dangerous.

Kind regards

     Andreas.

On Tue, May 26, 2020 at 11:31:32AM +0530, Nilesh Patra wrote:

> Hi,
> Currently r-cran-sjplot, r-cran-sjmisc have failing tests, and have RC bugs
> - #961498 and  #961499 filed against them.
> I have fixed these and pushed my changes to the team repos here[1] and
> here[2].
> Need review and sponsorship.
>
> [1]: https://salsa.debian.org/r-pkg-team/r-cran-sjplot
> [2]: https://salsa.debian.org/r-pkg-team/r-cran-sjmisc
>
> Thanks and regards
> Nilesh

--
http://fam-tille.de

Reply | Threaded
Open this post in threaded view
|

Bug#961499: [RFS] r-cran-sjplot and r-cran-sjmisc

Nilesh Patra
Hi

On Tue, 26 May 2020, 13:26 Andreas Tille, <[hidden email]> wrote:
Hi Nilesh,

same as for r-cran-sjplot:  In commit d2c969cc you move a file out of
help system to doc and I'm not convinced that this is not dangerous.

Ahh, righty!
I didn't realise the help system thing while moving it, and this was indeed a careless mistake. Apologies.

I've reverted the commit and pushed for both the packages.
Please consider to upload.

Regards,
Nilesh

Reply | Threaded
Open this post in threaded view
|

Bug#961499: [RFS] r-cran-sjplot and r-cran-sjmisc

Andreas Tille-5
Hi Nilesh,

On Tue, May 26, 2020 at 02:16:35PM +0530, Nilesh Patra wrote:
> > same as for r-cran-sjplot:  In commit d2c969cc you move a file out of
> > help system to doc and I'm not convinced that this is not dangerous.
>
> Ahh, righty!
> I didn't realise the help system thing while moving it, and this was indeed
> a careless mistake. Apologies.

Really no need to apologise - mistakes just happen.
 
> I've reverted the commit and pushed for both the packages.
> Please consider to upload.

First package uploaded, second just building.  Thanks a lot for your
contribution

      Andreas.

--
http://fam-tille.de

Reply | Threaded
Open this post in threaded view
|

Bug#961499: marked as done (r-cran-sjmisc: missing test dependency on r-cran-haven)

Debian Bug Tracking System
In reply to this post by Adrian Bunk-3
Your message dated Tue, 26 May 2020 10:04:00 +0000
with message-id <[hidden email]>
and subject line Bug#961499: fixed in r-cran-sjmisc 2.8.4-3
has caused the Debian Bug report #961499,
regarding r-cran-sjmisc: missing test dependency on r-cran-haven
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [hidden email]
immediately.)


--
961499: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=961499
Debian Bug Tracking System
Contact [hidden email] with problems

Source: r-cran-sjmisc
Version: 2.8.4-2
Severity: serious

https://ci.debian.net/data/autopkgtest/testing/amd64/r/r-cran-sjmisc/5633123/log.gz

...
── 1. Error: (unknown) (@test-frq_whitespace.R#10)  ────────────────────────────
Package 'haven' required for this function. Please install it.
Backtrace:
 1. sjmisc::rec(dat, y.char, suffix = "_r", as.num = TRUE, rec = "Category1 = 1 [Label 1]; Category2 = 2 [Label 2]; Category3 = 3 [Label 3];")
 2. sjmisc:::rec.default(...)
 3. sjmisc:::rec_core_fun(...)
 4. sjmisc:::rec_helper(...)
 7. sjlabelled::set_labels(x = new_var, labels = val_lab)
 8. sjlabelled:::set_labels_helper(...)
...


r-cran-sjlabelled no longer depends on r-cran-haven.

Source: r-cran-sjmisc
Source-Version: 2.8.4-3
Done: Nilesh Patra <[hidden email]>

We believe that the bug you reported is fixed in the latest version of
r-cran-sjmisc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [hidden email],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nilesh Patra <[hidden email]> (supplier of updated r-cran-sjmisc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [hidden email])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 26 May 2020 10:57:37 +0530
Source: r-cran-sjmisc
Architecture: source
Version: 2.8.4-3
Distribution: unstable
Urgency: medium
Maintainer: Debian R Packages Maintainers <[hidden email]>
Changed-By: Nilesh Patra <[hidden email]>
Closes: 961499
Changes:
 r-cran-sjmisc (2.8.4-3) unstable; urgency=medium
 .
   * Team Upload.
   * Update Test Depends (Closes: #961499)
   * Bump debhelper-compat version to 13
Checksums-Sha1:
 bed7944aa6949cd191bdb247a0aefae180d6b7e8 2265 r-cran-sjmisc_2.8.4-3.dsc
 d3571125443cec699f671bef95688fc2ade14dde 2732 r-cran-sjmisc_2.8.4-3.debian.tar.xz
 02cf6e3f4cb38b451df6b7474eeab24260741dea 9302 r-cran-sjmisc_2.8.4-3_amd64.buildinfo
Checksums-Sha256:
 80df368990da270709d1e234fa46405a7e8bf48f0ec6137826f79b5f701cffb5 2265 r-cran-sjmisc_2.8.4-3.dsc
 8da525c2a77eee003a78434271638fb4bc6589003c2ebf4bef3931b84349c439 2732 r-cran-sjmisc_2.8.4-3.debian.tar.xz
 e5c0f73d43752facbf4f3afecb5122e59d15d7165f7d534c7fcffca1f86b0faa 9302 r-cran-sjmisc_2.8.4-3_amd64.buildinfo
Files:
 38e5e575ad3780b584a2ef282d65d93e 2265 gnu-r optional r-cran-sjmisc_2.8.4-3.dsc
 a797baa0460c767533e70d09dbd9a29c 2732 gnu-r optional r-cran-sjmisc_2.8.4-3.debian.tar.xz
 6947cb4a96a8b7e57f25ca02d3984762 9302 gnu-r optional r-cran-sjmisc_2.8.4-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAl7M5BkRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtEA9A/9Egm37d+JtiP738CdF+5dB7pV5I5rqGWx
oDazkcBvoEJsFFg3zK+mL6WcgZKKgKEPTmop2nxK82n/cxTCYctxUPTY6a9mKRPo
vNBRjRckTcnYnvQ5KWo9K7MJWfMwwAmZN9T6YCyvfd+OKNan1diGu2SpFYBQV4Qd
V5yLlIsLqX/sR7H372EOre7qsdpzsm95HQReKsKzekHrLH/FH/+fN5BLfGoFD426
yx2tozDKjXDqhzPfNODkuqfBTtBDp4GOqTz0FmBdqHJvRLESZ5GWirpmaIlGIb4O
i8mZqDA0fr65zqWZaJeFWlBg0pDz8dlP2XGdCJhnZaZ27P7Bm9Cr816nou2rg3pJ
kiG37qdfwkewEknO/PQ+zVHWDWF2unLmPkzmXHMhMlWlaHNSyPnNFTHQ/E75FIEr
sDzl4CMxaeWZDGd5BPDQD+zH6k2pxxB6j65cF37/EUN23Fx7rKoosxNV15FBLH7+
hC3a97VQK+u1H/JE0/ZfTAPe5Uv9LIJ9EKz6O6pVpm+N2m685M4mJWy2u7hgHEP9
gtG72uyX6hiydq2eF/7PJSRnpVfDqapcstw59Qx2yN6xby6O/ASO0unONLHQ6Uif
Z7uZ/uRR4BjXYfJCrp2L5zBGMvQ+XNTwgU4mtV0D6VlgVRUco1TnsUj9hg5c6y/r
zxquPm03Btc=
=u9Nr
-----END PGP SIGNATURE-----