Fwd: [gnome-flashback] Releasing gnome-panel 3.8.1, 3.10 for trusty ?, the state of master, RFH for code review

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

Fwd: [gnome-flashback] Releasing gnome-panel 3.8.1, 3.10 for trusty ?, the state of master, RFH for code review

shirish शिरीष
Dear gentleman,
As can be seen in the forwarded the maintainer of gnome-flashback is
asking for help in code review and comments on state of patches for
various branches of gnome-panel. Could 1 or 2 people from the
debian-gnome team take some time out and help out with the needful.

The benefits of this would be for people like me who like the
gnome2ish look while working with GNOME 3 components. It's possible
that some of this work may directly or indirectly also help the
derivative mate desktop as well.

Hopefully some people come forward.

The post in gnome-flashback archive list


---------- Forwarded message ----------
From: Philipp Kaluza <[hidden email]>
Date: Tue, 08 Jul 2014 19:56:26 +0200
Subject: [gnome-flashback] Releasing gnome-panel 3.8.1, 3.10 for
trusty ?, the state of master, RFH for code review
To: Mailing list for the Gnome Flashback project
<[hidden email]>, Sebastian Geiger <[hidden email]>,
Dmitry Shachnev <[hidden email]>

Hi All,

as you may know, gnome-panel master has been a huge grab-bag of stuff
and fluff since shortly after the 3.8.0 release, containing some good
(and important) bug fixes, dependency bumps, ABI breaks, code
modernization patches, and translation updates.

For this reason it's not possible to just cut a 3.8.1 release from
master as some have suggested - we need to stay compatible to the Gnome
3.8 release, the ABI we shipped with 3.8.0, and the dependency
requirements we published at that time.

I have now finally finished reviewing all the commits that went into the
master branch more or less unsorted - only a tiny fraction has ever
received proper code review.

I created a CSV table, attached, which lists which commit should go into
each branch. Feedback on this is very welcome.

Credit where credit is due, the majority of this work has been created
by Alberts Muskupavels (at least as far as the patch authorship
information is correct).

The next step is to cut a 3.8.1 release (from the gnome-3-8 branch
I have pushed the relevant code commits to that branch. Translation
commits will follow.

I have resurrected a saucy system with mixed Gnome 3.8 / Gnome 3.10
components, and the branch builds and works there, even loading applets
from the old gnome-applets 3.6.5 package.
(TODO: test jhbuild of 3.8 also)

Please test building and running the gnome-3-8 branch, especially on
Gnome 3.8 and 3.10 installations and in jhbuild.

@lanoxx: I have marked your .ui file modernization patches as being OK
to go into 3.8 - does that seem sensible to you ?


QUESTION to Ubuntu downstreams: You were the only ones that seemed
interested in getting a gnome-panel 3.10 release done. Is anybody still
interested in creating a backport for this  in trusty, and seeing it
through to completions ?

If not, I'm inclined to skip 3.10 completely. Please answer until
Saturday at the latest.

I'm also looking for help to conduct a proper code review round on all
the work in master. Please check the CSV file, if the split of patches
into feature branches makes sense. Then I will publish proper RFCs for
each branch on this ML¹, and am hoping the other devs / downstreams will
help me to review this work.

¹ (As I had asked the author to do, who couldn't be bothered.)

And as always, Gnome Flashback needs some love, resurrecting the missing
gnome-settings-daemon parts. (I know ubuntu downstream has created a
workaround, in the form of a g-s-d fork. Upstream we are still in bad
shape on this front, and AFAICT so is GF in Debian.)


Philipp Kaluza
Ghostroute IT Consulting

          Shirish Agarwal  शिरीष अग्रवाल
  My quotes in this email licensed under CC 3.0
EB80 462B 08E1 A0DE A73A  2C2F 9F3D C7A4 E1C4 D2D8

review-master-commits.csv (8K) Download Attachment