[G-I] testresults using new gtk2-engines udeb

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[G-I] testresults using new gtk2-engines udeb

Frans Pop-3
I have just tested the image created yesterday by Davide. The installer
looks very nice, it solves the bug where the selected item in multiselect
lists is not displayed and I've seen no regressions.

There is one minor issue. VT1 gets flooded with two messages:
* Repeated a lot:
  (debconf: 9999): Gdk-DirectFB-WARNING **: gdk_directfb_gc_set_dashes not implemented
* Repeated a lot while progress bar is running:
  Gdk_DirectFB-Message: filled polygons with n > 3 are not yet supported, drawing outlines

Seems like the engine uses some "advanced" features that are not supported
by gdk-directfb, though it does seem to cleanly fall back to alternatives.
I'd like to prevent the flooding of VT1 though; would it be possible to
suppress these warnings?

I have one question: how will implementing this clearlooks engine affect
implementing the bladr and "dark" theme? I'd like to avoid implementing
several different themes/engines for Etch and instead stick to only:
- one default theme
- the dark theme (or rather one theme for visually impaired people)

Cheers,
FJP

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Attilio Fiandrotti-3
Frans Pop wrote:

> I have just tested the image created yesterday by Davide. The installer
> looks very nice, it solves the bug where the selected item in multiselect
> lists is not displayed and I've seen no regressions.
>
> There is one minor issue. VT1 gets flooded with two messages:
> * Repeated a lot:
>   (debconf: 9999): Gdk-DirectFB-WARNING **: gdk_directfb_gc_set_dashes not implemented
> * Repeated a lot while progress bar is running:
>   Gdk_DirectFB-Message: filled polygons with n > 3 are not yet supported, drawing outlines
>
> Seems like the engine uses some "advanced" features that are not supported
> by gdk-directfb, though it does seem to cleanly fall back to alternatives.
> I'd like to prevent the flooding of VT1 though; would it be possible to
> suppress these warnings?
That's because filled polygon with more than 3 edges drawing is not
currently supported: a patch for this exists, but wasn't committed yet
AFAIK [1].
To prevent VT1 pollution, such warnings could be simply silenced (see
attached patch).

> I have one question: how will implementing this clearlooks engine affect
> implementing the bladr and "dark" theme? I'd like to avoid implementing
> several different themes/engines for Etch and instead stick to only:
> - one default theme
> - the dark theme (or rather one theme for visually impaired people)

AFAIK, Bladr and the dark theme are no longer needed / applicable, as
they use the libpixmap engine, not clearlooks, and should not be
packaged in the g-i.
IIRC, loic has also packages the h(igh)c(ontrast)engine engine, which
should be ok to implement accessibility.
We may need tweak something in rootskel-gtk to allow GTK theme choose at
boot time.

cheers

Attilio

[1] http://mail.directfb.org/pipermail/directfb-dev/2006-October/002387.html

Index: gdkdrawable-directfb.c
===================================================================
RCS file: /cvs/gnome/gtk+/gdk/directfb/gdkdrawable-directfb.c,v
retrieving revision 1.6
diff -u -r1.6 gdkdrawable-directfb.c
--- gdkdrawable-directfb.c      11 Aug 2006 05:44:46 -0000      1.6
+++ gdkdrawable-directfb.c      13 Oct 2006 13:44:28 -0000
@@ -526,9 +526,9 @@

             return;
           }
-                else
-                        g_message ("filled polygons with n > 3 are not yet supported, "
-                     "drawing outlines");
+//                else
+//                        g_message ("filled polygons with n > 3 are not yet supported, "
+//                     "drawing outlines");
     }

   if (points[0].x != points[npoints-1].x ||
Index: gdkgc-directfb.c
===================================================================
RCS file: /cvs/gnome/gtk+/gdk/directfb/gdkgc-directfb.c,v
retrieving revision 1.1
diff -u -r1.1 gdkgc-directfb.c
--- gdkgc-directfb.c    5 Feb 2006 04:04:28 -0000       1.1
+++ gdkgc-directfb.c    13 Oct 2006 13:44:28 -0000
@@ -334,7 +334,7 @@
                             gint8  dash_list[],
                             gint   n)
 {
-  g_warning ("gdk_directfb_gc_set_dashes not implemented");
+//  g_warning ("gdk_directfb_gc_set_dashes not implemented");
 }

 static void
Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Loïc Minier
In reply to this post by Frans Pop-3
On Fri, Oct 13, 2006, Frans Pop wrote:
> There is one minor issue. VT1 gets flooded with two messages:
> * Repeated a lot:
>   (debconf: 9999): Gdk-DirectFB-WARNING **: gdk_directfb_gc_set_dashes not implemented
> * Repeated a lot while progress bar is running:
>   Gdk_DirectFB-Message: filled polygons with n > 3 are not yet supported, drawing outlines
> Seems like the engine uses some "advanced" features that are not supported
> by gdk-directfb, though it does seem to cleanly fall back to alternatives.
> I'd like to prevent the flooding of VT1 though; would it be possible to
> suppress these warnings?

 gdk_directfb_gc_set_dashes() and filled polygons with n > 3 aren't
 implemented in Gtk 2.10.6 either, so a backport wouldn't help.  I'm
 afraid that use of these functions would have to be changed in the
 Clearlooks engine and we would have to change the build to apply
 different patches to the directfb build; this would be relatively hard.
   I'm afraid that warnings are always printed by default, I couldn't
 find a way to turn them off without adding a special log handler.  :-/
 (The relevant code is in glib/gmessages.c in glib2.0, and the doc is
 at <http://developer.gnome.org/doc/API/2.0/glib/glib-running.html>.)

> I have one question: how will implementing this clearlooks engine affect
> implementing the bladr and "dark" theme? I'd like to avoid implementing
> several different themes/engines for Etch and instead stick to only:
> - one default theme
> - the dark theme (or rather one theme for visually impaired people)

 You definitely want a theme for visually impaired people, I've added
 libhcengine.so the gtk2-engines udeb, which enhances the look ot the
 High Constrast theme.  It seems to reference
 /usr/share/themes/HighContrastLargePrint/pixmaps, but
 /usr/share/themes/HighContrast/gtk-2.0/gtkrc is probaly the bulk of the
 theme, and it would be a good start to try using this gtkrc.

 (Please let me know ahead of time if you need a gnome-themes udeb as
 well, but it would be easier to grab a copy from the relevant files
 and ship them in rootskel for now.)

 I didn't look into the Bladr theme.

 I'm not sure how you'll switch theme when someone wants the
 accessibility mode of the installer, do you have a solution for this
 already?  Will you generate a gtkrc in /etc?

--
Loïc Minier <[hidden email]>


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Loïc Minier
In reply to this post by Frans Pop-3
On Fri, Oct 13, 2006, Frans Pop wrote:
>   (debconf: 9999): Gdk-DirectFB-WARNING **: gdk_directfb_gc_set_dashes not implemented
>   Gdk_DirectFB-Message: filled polygons with n > 3 are not yet supported, drawing outlines

 These warnings are likely to go away with gtk2-engines 2.8, since some
 parts of the engine where gdk_gc_set_dashes() and gdk_region_polygon()
 appear were rewritten to be based on Cairo instead.

 I'll forward port the udeb to 2.8 which we considered for etch anyway.


 (Actually, the only blocker for gtk2-engines in etch so far is
 precisely the rewrite to Cairo of some engines which exposed some
 glitches in particular combinations of Cairo based engines + Xorg
 architecture (EXA/XAA) + ATI driver, and it seems there's a patch
 upstream for the ati driver.)
--
Loïc Minier <[hidden email]>


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Josselin Mouette
In reply to this post by Frans Pop-3
Le vendredi 13 octobre 2006 à 15:22 +0200, Frans Pop a écrit :

> I have just tested the image created yesterday by Davide. The installer
> looks very nice, it solves the bug where the selected item in multiselect
> lists is not displayed and I've seen no regressions.
>
> There is one minor issue. VT1 gets flooded with two messages:
> * Repeated a lot:
>   (debconf: 9999): Gdk-DirectFB-WARNING **: gdk_directfb_gc_set_dashes not implemented
> * Repeated a lot while progress bar is running:
>   Gdk_DirectFB-Message: filled polygons with n > 3 are not yet supported, drawing outlines
>
> Seems like the engine uses some "advanced" features that are not supported
> by gdk-directfb, though it does seem to cleanly fall back to alternatives.
> I'd like to prevent the flooding of VT1 though; would it be possible to
> suppress these warnings?

These warnings use g_warning and g_message, which cannot be deactivated
at runtime. We can still patch the source to remove these warnings, but
it's kind of ugly.

> I have one question: how will implementing this clearlooks engine affect
> implementing the bladr and "dark" theme? I'd like to avoid implementing
> several different themes/engines for Etch and instead stick to only:
> - one default theme
> - the dark theme (or rather one theme for visually impaired people)

The udeb also includes the hcengine.so engine, so that you can ship a
dark theme using this engine as well. Once the engine is available,
shipping one of the gtkrc files from gnome-accessibility-themes should
be enough.
--
 .''`.           Josselin Mouette        /\./\
: :' :           [hidden email]
`. `'                        [hidden email]
   `-  Debian GNU/Linux -- The power of freedom

Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Frans Pop-3
In reply to this post by Loïc Minier
On Friday 13 October 2006 15:57, Loïc Minier wrote:
>    I'm afraid that warnings are always printed by default, I couldn't
>  find a way to turn them off without adding a special log handler.  :-/
>  (The relevant code is in glib/gmessages.c in glib2.0, and the doc is
>  at <http://developer.gnome.org/doc/API/2.0/glib/glib-running.html>.)

OK. If there is no acceptable way to turn them off, I guess we'll have to
live with them. It's mostly that I'd like to avoid unnecessary BRs from
users who see the errors and also give really meaningful errors a chance
of actually being seen...

Let's see if your backporting attempts bring something.
 
BTW, are these messages also written to a logfile somewhere?

>  (Please let me know ahead of time if you need a gnome-themes udeb as
>  well, but it would be easier to grab a copy from the relevant files
>  and ship them in rootskel for now.)

Yes, shipping them in rootskel-gtk is what we were planning to do.

>  I'm not sure how you'll switch theme when someone wants the
>  accessibility mode of the installer, do you have a solution for this
>  already?  Will you generate a gtkrc in /etc?

We already have an implementation for that. Basic trigger is passing
"theme=xxxx" at the boot prompt.

Thx,
FJP

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Loïc Minier
On Fri, Oct 13, 2006, Frans Pop wrote:
> OK. If there is no acceptable way to turn them off, I guess we'll have to
> live with them. It's mostly that I'd like to avoid unnecessary BRs from
> users who see the errors and also give really meaningful errors a chance
> of actually being seen...

 Understood.  The clean way would to turn them off conditionally, for
 example only for g-i.  Sample possible ways:
 - gtk/dfb:
   . build gtk one more time for g-i (curently, the directfb build is used
     both for regular *.debs and for the udeb)
   . add a buildtime condition in a patch for gtk which only affects the
     g-i build
 - gtk/dfb + g-i:
   . add a runtime condition in a patch for gtk which turns off warnings
     when a certain condition is met (environment var, file...)
   . meet that condition in g-i
 - gtk2-engines:
   . add a buildtime condition in a patch for gtk2-engines which only
     affects the g-i build
   . add a log handler to filter out these events in the patch

 But let us explore the backport of gtk2-engines 2.8 first.  :-P

> BTW, are these messages also written to a logfile somewhere?

 No.

--
Loïc Minier <[hidden email]>


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Frans Pop-3
On Friday 13 October 2006 18:05, Loïc Minier wrote:
>  But let us explore the backport of gtk2-engines 2.8 first.  :-P

Tested with backported package from:
http://people.dooz.org/~lool/debian/gtk2-engines/2.8.1-3/sid-pbuilder/

With this the warning messages have disappeared and the progress bar looks
a lot nicer.

Thanks Loïc!

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Frans Pop-3
In reply to this post by Loïc Minier
On Friday 13 October 2006 15:57, Loïc Minier wrote:
> You definitely want a theme for visually impaired people, I've added
> libhcengine.so the gtk2-engines udeb, which enhances the look ot the
> High Constrast theme.

OK. Cool.
Just checked and the patch for a theme for visually impaired people that
Denis Barbier prepared actually already uses HC, so no problem there.

So we just need a replacement for the bladr-based theme requested in
#390435.

We added /usr/lib/gtk-2.0/2.4.0/engines/libpixmap.so in
libgtk-directfb-2.0-0-udeb to support the bladr theme. If we actually
drop bladr and go with clearlooks for the default theme, and the
libpixmap lib is not needed for that, it'd be nice if we could drop it
again from the udeb. No real rush though.

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Frans Pop-3
Sorry for replying to myself...

On Friday 13 October 2006 19:30, Frans Pop wrote:
> We added /usr/lib/gtk-2.0/2.4.0/engines/libpixmap.so in
> libgtk-directfb-2.0-0-udeb to support the bladr theme. If we actually
> drop bladr and go with clearlooks for the default theme, and the
> libpixmap lib is not needed for that, it'd be nice if we could drop it
> again from the udeb. No real rush though.

Turns out that there is a much simpler way to activate the Clearlooks
engine than using:
include "/usr/share/themes/Clearlooks/gtk-2.0/gtkrc"

And that is (of course...):
gtk-theme-name = "Clearlooks"

This also means that if we want to customize this theme (e.g. make it red
instead of blue), we either need to _not_ include the Clearlooks gtkrc
file in gtk2-engines-udeb, or we need to provide Loïc with the version
we'd want to use.

My personal preference would be to, at least for now, drop it from the
udeb and include it in rootskel-gtk ourselves as that gives the greater
flexibility (it is much easier to upload and push rootskel-gtk than a
Gnome team package).
We can always move it back once the theme is mature for our needs.

I'd also like to clean up the theme file by using tabs instead of spaces
everywhere as that saves some valuable memory.

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Loïc Minier
On Fri, Oct 13, 2006, Frans Pop wrote:
> My personal preference would be to, at least for now, drop it from the
> udeb and include it in rootskel-gtk ourselves as that gives the greater
> flexibility (it is much easier to upload and push rootskel-gtk than a
> Gnome team package).
> We can always move it back once the theme is mature for our needs.

 I've uploaded gtk2-engines 1:2.8.1-3 to unstable, and dropped the
 gtkrc; you should now include it in rootskel.

--
Loïc Minier <[hidden email]>


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [G-I] testresults using new gtk2-engines udeb

Loïc Minier
In reply to this post by Frans Pop-3
On Fri, Oct 13, 2006, Frans Pop wrote:
> We added /usr/lib/gtk-2.0/2.4.0/engines/libpixmap.so in
> libgtk-directfb-2.0-0-udeb to support the bladr theme. If we actually
> drop bladr and go with clearlooks for the default theme, and the
> libpixmap lib is not needed for that, it'd be nice if we could drop it
> again from the udeb. No real rush though.

 I've uploaded gtk+2.0 2.8.20-3 which drops this engines again, and adds
 the strdup() fix which seems required here as well.

--
Loïc Minier <[hidden email]>


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]