[PATCH] manual: provide a download command

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] manual: provide a download command

Michael Stapelberg-25
Instead of sending the user away to figure out which of the many files
they need, why don’t we just provide the correct command right there,
right now?

Patch attached, please consider merging. Thank you.

PS: I was reading
https://www.debian.org/releases/stable/amd64/ch04s03.html.en#usb-copy-isohybrid,
so I hope my patch changes the correct file.

--
Best regards,
Michael

usb-image-download.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] manual: provide a download command

Ben Hildred-3


On Fri, Oct 13, 2017 at 10:25 AM, Michael Stapelberg <[hidden email]> wrote:
Instead of sending the user away to figure out which of the many files
they need, why don’t we just provide the correct command right there,
right now?
Great Idea. 

Patch attached, please consider merging. Thank you.

Not such a great patch. Firstly although wget will work fine, since this is a html document it is probably being read in a browser which can just download the image by following the hyperlink, if it was a href. Second you hard linked stretch instead of stable. Third you hardcoded the architecture. And just to round things out this does not work with mirror choice (not as big of an issue).
 
PS: I was reading
https://www.debian.org/releases/stable/amd64/ch04s03.html.en#usb-copy-isohybrid,
so I hope my patch changes the correct file.

--
Best regards,
Michael



--
--
Ben Hildred
Automation Support Services

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] manual: provide a download command

Michael Stapelberg-25
On Fri, Oct 13, 2017 at 10:38 AM, Ben Hildred <[hidden email]> wrote:

>
>
> On Fri, Oct 13, 2017 at 10:25 AM, Michael Stapelberg <[hidden email]>
> wrote:
>>
>> Instead of sending the user away to figure out which of the many files
>> they need, why don’t we just provide the correct command right there,
>> right now?
>
> Great Idea.
>>
>>
>> Patch attached, please consider merging. Thank you.
>>
> Not such a great patch. Firstly although wget will work fine, since this is
> a html document it is probably being read in a browser which can just
> download the image by following the hyperlink, if it was a href. Second you
> hard linked stretch instead of stable. Third you hardcoded the architecture.
> And just to round things out this does not work with mirror choice (not as
> big of an issue).

Can you explain how to fix these issues please? I’m not familiar with
our tooling.

>
>>
>> PS: I was reading
>>
>> https://www.debian.org/releases/stable/amd64/ch04s03.html.en#usb-copy-isohybrid,
>> so I hope my patch changes the correct file.
>>
>> --
>> Best regards,
>> Michael
>
>
>
>
> --
> --
> Ben Hildred
> Automation Support Services
>



--
Best regards,
Michael

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] manual: provide a download command

Cyril Brulebois-4
In reply to this post by Michael Stapelberg-25
Hi,

Michael Stapelberg <[hidden email]> (2017-10-13):

> Index: en/install-methods/boot-usb-files.xml
> ===================================================================
> --- en/install-methods/boot-usb-files.xml (revision 70855)
> +++ en/install-methods/boot-usb-files.xml (working copy)
> @@ -41,8 +41,12 @@
>  Alternatively,
>  for very small USB sticks, only a few megabytes in size, you can download
>  the <filename>mini.iso</filename> image from the <filename>netboot</filename>
> -directory (at the location mentioned in <xref linkend="where-files"/>).
> +directory:
>  
> +<informalexample><screen>
> +<prompt>#</prompt> <userinput>wget http://deb.debian.org/debian/dists/stretch/main/installer-amd64/current/images/netboot/mini.iso</userinput>
> +</screen></informalexample>
> +
Please don't encourage people to download installation images over HTTP,
especially not when HTTPS is available…


KiBi.

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] manual: provide a download command

Philipp Kern-2
On 10/13/2017 10:43 PM, Cyril Brulebois wrote:

> Michael Stapelberg <[hidden email]> (2017-10-13):
>> Index: en/install-methods/boot-usb-files.xml
>> ===================================================================
>> --- en/install-methods/boot-usb-files.xml (revision 70855)
>> +++ en/install-methods/boot-usb-files.xml (working copy)
>> @@ -41,8 +41,12 @@
>>  Alternatively,
>>  for very small USB sticks, only a few megabytes in size, you can download
>>  the <filename>mini.iso</filename> image from the <filename>netboot</filename>
>> -directory (at the location mentioned in <xref linkend="where-files"/>).
>> +directory:
>>  
>> +<informalexample><screen>
>> +<prompt>#</prompt> <userinput>wget http://deb.debian.org/debian/dists/stretch/main/installer-amd64/current/images/netboot/mini.iso</userinput>
>> +</screen></informalexample>
>> +
>
> Please don't encourage people to download installation images over HTTP,
> especially not when HTTPS is available…
Note: https://www.debian.org/releases/stretch/amd64/ch04s02.html.en is
the canonical link the "where-files" xref links to. That points to a
HTTP-only http.us.debian.org, which is internally composed from
"&url-debian-installer;".

From urls.ent that's because &disturl; embeds &url-archive; which embeds
&archive-mirror;, which is http.us.debian.org. There are also various
HTTP-only links in there.

Should we go and just replace that with deb.debian.org, which presumably
has all architectures, and convert (most of) the links to HTTPS?

We could then still apply Michael's patch, as long as we use
&url-debian-installer; properly for the URL. (The link wouldn't work
as-is anyway because it should use &releasename; instead of hard-coding
"stretch".)

Kind regards and thanks
Philipp Kern


signature.asc (523 bytes) Download Attachment