Possible workaround to this bug

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Possible workaround to this bug

Attilio Fiandrotti-3
Hi

Today Rui Lopes proposed a workaround to this bug: using the clearlooks
GTK engine to perform widget drawing.
As Rui proved, clearlooks engine performs correctly all those widget
rendering operations that are badly performed by gtkdfb (libpixmap?).
Both Rui and me were able to compile corretly the engine library and
also to run successfully the cdebconf with GTK frontend, the GIMP and
the gtk-demo app.
This bug was already reported upstream and GTKDFB maintainer said he now
has a clue about where to look at to fix it.
But, as d-i RC1 date is getting closer and he may not make it in time,
having an option to a proper fix for this bug may be advisable.
With this mail i'm trying to investigate if using the clearlooks engine
as default in the graphical debian-installer is a reasonable idea.

thanks

Attilio

test_multiselect_clearlooks.png (46K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Possible workaround to this bug

Loïc Minier
On Wed, Oct 11, 2006, Attilio Fiandrotti wrote:
> With this mail i'm trying to investigate if using the clearlooks engine
> as default in the graphical debian-installer is a reasonable idea.

 Do you want me to upload a Gtk 2.10 with clearlooks?

 Would you need the strndup() and clearlooks in 2.8 right now?

--
Loïc Minier <[hidden email]>


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Possible workaround to this bug

Attilio Fiandrotti-3
Loïc Minier wrote:
> On Wed, Oct 11, 2006, Attilio Fiandrotti wrote:
>
>>With this mail i'm trying to investigate if using the clearlooks engine
>>as default in the graphical debian-installer is a reasonable idea.
>
>
>  Do you want me to upload a Gtk 2.10 with clearlooks?
>
>  Would you need the strndup() and clearlooks in 2.8 right now?

(cc'ing d-boot as this is related to both gtk and d-i)

As frans said [1], we're going with GTK 2.8.20 for Etch, so i guess we
should upload a GTK 2.8.20 with clearlooks: Loic, is this possible /
advisable?
I see that the only clearlooks engine, stripped, is ~ 80 KB big, and the
theme is ~60KB big, where 40 KB are for the metacity theme.
As we don't need no window manager, would it be possible not including
that metacity theme inside the package?
This way, the Clearlooks stuff would be only ~100KB big, and if we
really desire save up more space, we could even remove the libpixmap
engine, which is ~30KB big (but if it's possible i would libpixmap in
place for future use).
About backporting the g_strdup() bug (which doesn't apper in GTK 2.8 but
only in GTK 2.10), we should more generally decide wheter or not
backport other possible fixes that actually give no benefit to the g-i.
Anyway, if you decide to backport this fix, it's harmless (at worst
we'll leak some bytes).
I really suggest including the clearlooks engine into the gtkdfb udeb
right now, test it and make sure it works correctly in the case this
bugs couldn't be fixed in time for RC1.

cheers

Attilio

[1] http://lists.debian.org/debian-boot/2006/10/msg00358.html


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Bug#385026: Possible workaround to this bug

Josselin Mouette
Le jeudi 12 octobre 2006 à 10:19 +0200, Attilio Fiandrotti a écrit :
> I really suggest including the clearlooks engine into the gtkdfb udeb
> right now, test it and make sure it works correctly in the case this
> bugs couldn't be fixed in time for RC1.

In all cases this would have to be a different udeb, as clearlooks is
included in the gtk2-engines source.

It also means revamping the gtk2-engines build process so it's not
trivial, but certainly feasible.
--
 .''`.           Josselin Mouette        /\./\
: :' :           [hidden email]
`. `'                        [hidden email]
   `-  Debian GNU/Linux -- The power of freedom

Reply | Threaded
Open this post in threaded view
|

Re: Bug#385026: Possible workaround to this bug

Attilio Fiandrotti-3
Josselin Mouette wrote:

> Le jeudi 12 octobre 2006 à 10:19 +0200, Attilio Fiandrotti a écrit :
>
>>I really suggest including the clearlooks engine into the gtkdfb udeb
>>right now, test it and make sure it works correctly in the case this
>>bugs couldn't be fixed in time for RC1.
>
>
> In all cases this would have to be a different udeb, as clearlooks is
> included in the gtk2-engines source.
>
> It also means revamping the gtk2-engines build process so it's not
> trivial, but certainly feasible.

My idea was including clearlooks engine dfb flavour into
libgtk-directfb-2.0-0-udeb package.
I know this is not very clean, but as a temporary solution, given also
the time of the release we are , could be an acceptable solution.
Something similar [1] was also done to provide the g-i the dfbinfo tool.

cheers

Attilio

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=390437


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Bug#385026: Possible workaround to this bug

Eddy Petrișor
[this is just a "are we sure that what we're doing is necessary" mail]

Attilio Fiandrotti wrote:

> Josselin Mouette wrote:
>> Le jeudi 12 octobre 2006 à 10:19 +0200, Attilio Fiandrotti a écrit :
>>
>>> I really suggest including the clearlooks engine into the gtkdfb udeb
>>> right now, test it and make sure it works correctly in the case this
>>> bugs couldn't be fixed in time for RC1.
>>
>>
>> In all cases this would have to be a different udeb, as clearlooks is
>> included in the gtk2-engines source.
>>
>> It also means revamping the gtk2-engines build process so it's not
>> trivial, but certainly feasible.
>
> My idea was including clearlooks engine dfb flavour into
> libgtk-directfb-2.0-0-udeb package.
> I know this is not very clean, but as a temporary solution, given also
> the time of the release we are , could be an acceptable solution.
> Something similar [1] was also done to provide the g-i the dfbinfo tool.

I have seen that Denis Barbier was able to apply the hicontrast theme to
G-I just fine without the engine. Is the engine really necessary? (I
never understood what is the pupose of those, so I could use some light
on the subject).

--
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Bug#385026: Possible workaround to this bug

Josselin Mouette
Le jeudi 12 octobre 2006 à 17:47 +0300, Eddy Petrișor a écrit :
> [this is just a "are we sure that what we're doing is necessary" mail]
>
> Attilio Fiandrotti wrote:
> > My idea was including clearlooks engine dfb flavour into
> > libgtk-directfb-2.0-0-udeb package.
> > I know this is not very clean, but as a temporary solution, given also
> > the time of the release we are , could be an acceptable solution.
> > Something similar [1] was also done to provide the g-i the dfbinfo tool.

I'm afraid this is not possible. The engine will be in a new package.

> I have seen that Denis Barbier was able to apply the hicontrast theme to
> G-I just fine without the engine. Is the engine really necessary? (I
> never understood what is the pupose of those, so I could use some light
> on the subject).

If the bug is in the default engine, the engine is necessary.

Also, applying the highcontrast theme without the corresponding engine
leads to something less readable than what you get with the engine meant
for that.

BTW, if you need the highcontrast engine as well, it should be possible
now Loïc is building a gtk2-engines-udeb package.
--
 .''`.           Josselin Mouette        /\./\
: :' :           [hidden email]
`. `'                        [hidden email]
   `-  Debian GNU/Linux -- The power of freedom

Reply | Threaded
Open this post in threaded view
|

Re: Bug#385026: Possible workaround to this bug

Davide Viti
> BTW, if you need the highcontrast engine as well, it should be possible
> now Loïc is building a gtk2-engines-udeb package.

I've just built a g-i mini.iso [1] containing the udeb created by Loïc [2]

In case anyone wanted to try and rebuild it here's what I've done:

 * copy gtk2-engines-udeb_2.6.10-3_i386.udeb inside build/localudebs
 * add "gtk2-engines-udeb" in pkg-lists/gtk-common
 * checkout rootskel-gtk and add:

   include "/usr/share/themes/Clearlooks/gtk-2.0/gtkrc"

   at the end of src/etc/gtk-2.0/gtkrc; rebuild the udeb and copy it to build/localudebs

and finally rebuild the iso

hope this helps,
Davide


[1] http://www.webalice.it/zinosat/g-i/mini_engines.iso
[2] http://people.dooz.org/~lool/debian/gtk2-engines/2.6.10-3/sid-pbuilder/gtk2-engines-udeb_2.6.10-3_i386.udeb

signature.asc (196 bytes) Download Attachment