RFH: Bug#750902: ibus: Have unconditional B-D on libwayland-dev - prevents build on kfreebsd

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFH: Bug#750902: ibus: Have unconditional B-D on libwayland-dev - prevents build on kfreebsd

Osamu Aoki-5
Hi Gnome folks and Niels,

Ibus is the input method GNOME uses as default and I am adding the
wayland support.

I need help on the ibus bug #750902 but can not locate good examples to
follow.

On Sun, Jun 08, 2014 at 11:31:51AM +0200, Niels Thykier wrote:
> The ibus package added an unconditional Build-Depends on
> libwayland-dev, but libwayland-dev is currently only built on linux,
> whereas ibus has been built on kfreebsd and hurd.  This prevents ibus
> from being rebuilt in these architectures and thereby prevents ibus
> from migrating to testing.

True.
 
> Possible solutions include:
>  * Have wayland ported to kfreebsd (and hurd)

I am not seeking this path.

>  * Make ibus-wayland a linux-only binary and make the Build-Depends
>    a linux-any dependency

I want to do this but I am not quite sure what exactly to do.

What I need is an working example of existing package.  Can you point me
any good example?

My specific questions are how to update debian/control and debian/rules?

You say "linux-only" binary but what exactly should I use in the
debian/control?  linux-any seems to be the word used in the policy
( https://www.debian.org/doc/debian-policy/ch-customized-programs.html#s-arch-wildcard-spec )

Is this correct for debian/control?
 http://anonscm.debian.org/gitweb/?p=pkg-ime/ibus.git;a=blob;f=debian/control;hb=HEAD 
 
| Source: ibus
| ...
| Build-Depends: autoconf,
| ...
|                libwayland-dev [linux-any],
| ...
|
| Package: ibus-wayland
| Architecture: linux-any
| ...

Also, what is the most effective way to make debian/rules architecture
dependent?  I do not know how to set $(OS) elegantly.
 http://anonscm.debian.org/gitweb/?p=pkg-ime/ibus.git;a=blob;f=debian/rules;hb=HEAD

| ifdef ($(OS),linux-any)
| override_dh_auto_configure:
|         dh_auto_configure -- \
|                 --enable-wayland \
|                 --enable-introspection \
| ...
| else
| override_dh_auto_configure:
|         dh_auto_configure -- \
|                 --enable-introspection \
| ...
| endif

Your help to point me to the good example is most appreciated.

Regards,

Osamu


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: https://lists.debian.org/20140608161209.GA13088@goofy

Reply | Threaded
Open this post in threaded view
|

Re: RFH: Bug#750902: ibus: Have unconditional B-D on libwayland-dev - prevents build on kfreebsd

Simon McVittie-7
On 08/06/14 17:12, Osamu Aoki wrote:
> | Build-Depends: autoconf,
> | ...
> |                libwayland-dev [linux-any],

This looks correct. Builds of ibus on Linux will build-depend on
libwayland-dev, builds on non-Linux will not.

> | Package: ibus-wayland
> | Architecture: linux-any

This also looks correct. The binary package ibus-wayland will only be
built on Linux architectures.

> Also, what is the most effective way to make debian/rules architecture
> dependent?  I do not know how to set $(OS) elegantly.
>  http://anonscm.debian.org/gitweb/?p=pkg-ime/ibus.git;a=blob;f=debian/rules;hb=HEAD
>
> | ifdef ($(OS),linux-any)
> | override_dh_auto_configure:
> | ...
> | else
> | override_dh_auto_configure:
> | ...
> | endif

Include dpkg's default.mk ("include /usr/share/dpkg/default.mk", or use
architecture.mk instead if you would like to avoid also setting CFLAGS
and other useful variables), then use:

ifeq($(DEB_HOST_ARCH_OS),linux)
...       # Linux things here
else
...       # non-Linux things here
endif

Run dpkg-architecture to see other variables you can use.

telepathy-mission-control-5 is an example of a package with optional
Linux-specifics (we build with NetworkManager support on Linux only):

http://anonscm.debian.org/gitweb/?p=pkg-telepathy/telepathy-mission-control-5.git;a=blob;f=debian/rules;hb=HEAD
http://anonscm.debian.org/gitweb/?p=pkg-telepathy/telepathy-mission-control-5.git;a=blob_plain;f=debian/control;hb=HEAD

    S


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: https://lists.debian.org/5394A6EF.5050301@...

Reply | Threaded
Open this post in threaded view
|

Re: Bug#750902: RFH: Bug#750902: ibus: Have unconditional B-D on libwayland-dev - prevents build on kfreebsd

Osamu Aoki-5
Hi,

Simon, thanks for quick help.

Uploading it.

Osamu


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: https://lists.debian.org/20140609125232.GA321@goofy