[RFS] django-oauth-toolkit

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[RFS] django-oauth-toolkit

Nilesh Patra
Hi,
Currently django-oauth-toolkit FTBFS with python3.8. I have fixed it, and build + autopkgtest pass.
My changes have been pushed here [1].
Needs review and sponsorship.


Thanks and regards
Nilesh
Reply | Threaded
Open this post in threaded view
|

Re: [RFS] django-oauth-toolkit

Michael Fladischer
Hi Nilesh,


Am 15.03.2020 um 07:46 schrieb Nilesh Patra:
 > Needs review and sponsorship.

just a quick glance at the commits: you do not need to replace
autopkgtest-pkg-python with home-grown code, just tell it what to import:

echo oauth2_provider > debian/tests/pkg-python/import-name

Cheers,
Michael


Reply | Threaded
Open this post in threaded view
|

Re: Re: [RFS] django-oauth-toolkit

Nilesh Patra

> just a quick glance at the commits: you do not need to replace autopkgtest-pkg-python with home-grown code, just tell it what to import:

> echo oauth2_provider > debian/tests/pkg-python/import-name

Thanks, I didn't know about that. However, when I added that in, autopkgtest seems to fail with:

Removing autopkgtest-satdep (0) ...
autopkgtest [15:10:19]: test autodep8-python3: set -e ; for py in $(py3versions -r 2>/dev/null) ; do cd "$AUTOPKGTEST_TMP" ; echo "Testing with $py:" ; $py -c "import django_oauth_toolkit; print(django_oauth_toolkit)" ; done
autopkgtest [15:10:19]: test autodep8-python3: [-----------------------
Testing with python3.7:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'django_oauth_toolkit'
autopkgtest [15:10:19]: test autodep8-python3: -----------------------]
autopkgtest [15:10:20]: test autodep8-python3:  - - - - - - - - - - results - - - - - - - - - -
autodep8-python3     FAIL non-zero exit status 1
autopkgtest [15:10:20]: @@@@@@@@@@@@@@@@@@@@ summary
autodep8-python3     FAIL non-zero exit status 1

The command I used: sudo autopkgtest -B ../*.deb -- schroot unstable-amd64-sbuild
Am I missing something here? Need your guidance here.

Thanks and regards,
Nilesh
Reply | Threaded
Open this post in threaded view
|

Re: [RFS] django-oauth-toolkit

Michael Fladischer
Am 15.03.2020 um 10:54 schrieb Nilesh Patra:
> autopkgtest [15:10:19]: test autodep8-python3: set -e ; for py in $(py3versions -r 2>/dev/null) ; do cd "$AUTOPKGTEST_TMP" ; echo "Testing with $py:" ; $py -c "import django_oauth_toolkit; print(django_oauth_toolkit)" ; done

Are you sure that debian/tests/pkg-python/import-name has the correct
value? What does `cat debian/tests/pkg-python/import-name` show?

Anyways, thanks for your help, I made some minor tweaks and uploaded it
a few hours ago.

Cheers,
Michael

Reply | Threaded
Open this post in threaded view
|

Re: [RFS] django-oauth-toolkit

Nilesh Patra
> Are you sure that debian/tests/pkg-python/import-name has the correct
value?
I guess yes.

> What does `cat debian/tests/pkg-python/import-name` show?
[debian/master][~/packages/oauth-toolkit/django-oauth-toolkit]$ cat
debian/tests/pkg-python/import-name
oauth2_provider

Seems correct. I'm not really sure what is causing this.

> Anyways, thanks for your help, I made some minor tweaks and uploaded
it a few hours ago.
Thanks a lot for sponsoring the upload, :)
Could you as well review my changes for pytds[1] that are done here[2]?
That would be great.
I'm  planning to fix more packages in coming days, :)

[1]: https://lists.debian.org/debian-python/2020/03/msg00023.html
[2]: https://salsa.debian.org/gi-boi-guest/pytds

Thanks and regards,
Nilesh