RFS: libmoox-shorthas-perl

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

RFS: libmoox-shorthas-perl

Utkarsh Gupta
Hey,

I've prepared the Debian package of the module `MooX::ShortHas`.
The package was tested on sbuild and was successfully built. It was also
lintian clean.
I've pushed the package in the salsa repo which may be found at

Please consider to review and upload it.


Best,
Utkarsh
Reply | Threaded
Open this post in threaded view
|

Re: RFS: libmoox-shorthas-perl

Xavier Guimard-3
Le 10/06/2019 à 17:42, Utkarsh Gupta a écrit :
> Hey,
>
> I've prepared the Debian package of the module `MooX::ShortHas`.
> The package was tested on sbuild and was successfully built. It was also
> lintian clean.
> I've pushed the package in the salsa repo which may be found at
> https://salsa.debian.org/perl-team/modules/packages/libmoox-shorthas-perl
>
> Please consider to review and upload it.

Good work, I just added a little TODO

Reply | Threaded
Open this post in threaded view
|

Re: RFS: libmoox-shorthas-perl

Utkarsh Gupta
Hey,

On Mon, Jun 10, 2019 at 9:54 PM Xavier <[hidden email]> wrote:
Le 10/06/2019 à 17:42, Utkarsh Gupta a écrit :
> Hey,
>
> I've prepared the Debian package of the module `MooX::ShortHas`.
> The package was tested on sbuild and was successfully built. It was also
> lintian clean.
> I've pushed the package in the salsa repo which may be found at
> https://salsa.debian.org/perl-team/modules/packages/libmoox-shorthas-perl
>
> Please consider to review and upload it.

Good work, I just added a little TODO

I removed "${perl:Depends}" because while building locally, it gave me a warning that it is unused.
We normally remove it in Ruby gems as well (whenever it shows the warning).
Given that all other things went fine (including the installation), do we really need that?


Best,
Utkarsh
Reply | Threaded
Open this post in threaded view
|

Re: RFS: libmoox-shorthas-perl

Utkarsh Gupta
Hey,

On Mon, Jun 10, 2019 at 10:11 PM Utkarsh Gupta <[hidden email]> wrote:
Hey,

On Mon, Jun 10, 2019 at 9:54 PM Xavier <[hidden email]> wrote:
Le 10/06/2019 à 17:42, Utkarsh Gupta a écrit :
> Hey,
>
> I've prepared the Debian package of the module `MooX::ShortHas`.
> The package was tested on sbuild and was successfully built. It was also
> lintian clean.
> I've pushed the package in the salsa repo which may be found at
> https://salsa.debian.org/perl-team/modules/packages/libmoox-shorthas-perl
>
> Please consider to review and upload it.

Good work, I just added a little TODO

I removed "${perl:Depends}" because while building locally, it gave me a warning that it is unused.
We normally remove it in Ruby gems as well (whenever it shows the warning).
Given that all other things went fine (including the installation), do we really need that?

Update: I fixed the spelling error. And it is now ready for review and upload.
Let me know if you want me to revert the deletion of "${perl-Depends}".


Best,
Utkarsh
Reply | Threaded
Open this post in threaded view
|

Re: RFS: libmoox-shorthas-perl

gregor herrmann-3
On Mon, 10 Jun 2019 23:08:02 +0530, Utkarsh Gupta wrote:

> > I removed "${perl:Depends}" because while building locally, it gave me a
> > warning that it is unused.

> Let me know if you want me to revert the deletion of "${perl-Depends}".

I think the warning is related to the issue we discussed on IRC
earlier (files ending up below $HOME [0]), so when building in a
chroot the warning about ${perl:Depends} should be gone, and in all
but very uncommon cases it's also needed for perl packages (it's used
be dh_perl(1) for runtime dependencies).


Cheers,
gregor


[0] if you're not using local::lib deliberately, I'd still check the
output of `printenv' to see if there are any PERL_* environment
variables set

--
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-  

signature.asc (981 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: RFS: libmoox-shorthas-perl

Utkarsh Gupta
Hey,

On Tue, Jun 11, 2019 at 12:25 AM gregor herrmann <[hidden email]> wrote:
On Mon, 10 Jun 2019 23:08:02 +0530, Utkarsh Gupta wrote:

> > I removed "${perl:Depends}" because while building locally, it gave me a
> > warning that it is unused.

> Let me know if you want me to revert the deletion of "${perl-Depends}".

I think the warning is related to the issue we discussed on IRC
earlier (files ending up below $HOME [0]), so when building in a
chroot the warning about ${perl:Depends} should be gone, and in all
but very uncommon cases it's also needed for perl packages (it's used
be dh_perl(1) for runtime dependencies).


Cheers,
gregor


[0] if you're not using local::lib deliberately, I'd still check the
output of `printenv' to see if there are any PERL_* environment
variables set

Here are the PERL* env variables that I have:

PERL5LIB=/home/utkarsh2102/perl5/lib/perl5
PERL_LOCAL_LIB_ROOT=/home/utkarsh2102/perl5
PERL_MB_OPT=--install_base "/home/utkarsh2102/perl5"
PERL_MM_OPT=INSTALL_BASE=/home/utkarsh2102/perl5


Best,
Utkarsh
Reply | Threaded
Open this post in threaded view
|

Re: RFS: libmoox-shorthas-perl

gregor herrmann-3
On Wed, 12 Jun 2019 05:23:01 +0530, Utkarsh Gupta wrote:

> > I think the warning is related to the issue we discussed on IRC
> > earlier (files ending up below $HOME [0]),
[..]
> > [0] if you're not using local::lib deliberately, I'd still check the
> > output of `printenv' to see if there are any PERL_* environment
> > variables set

> Here are the PERL* env variables that I have:
>
> PERL5LIB=/home/utkarsh2102/perl5/lib/perl5
> PERL_LOCAL_LIB_ROOT=/home/utkarsh2102/perl5
> PERL_MB_OPT=--install_base "/home/utkarsh2102/perl5"
> PERL_MM_OPT=INSTALL_BASE=/home/utkarsh2102/perl5

And that exactly explains why perl modules get installed to
/home/utkarsh2102/perl5 in your "normal" enviroment :)

And as there is a PERL_LOCAL_LIB_ROOT variable, this looks very much
like you are after all using local::lib; at least "using" in the
sense of that someone/something sets these variables (maybe in
~/.bashrc or something similar).
Which is fine for using perl modules outside the system installation
but causes grieve when building packages (but that's what chroots are
for anyway).

Cheers,
gregor

--
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   BOFH excuse #232:  Ionization from the air-conditioning

Reply | Threaded
Open this post in threaded view
|

Re: RFS: libmoox-shorthas-perl

Utkarsh Gupta
Hey,

On Wed, Jun 12, 2019 at 11:59 AM gregor herrmann <[hidden email]> wrote:
On Wed, 12 Jun 2019 05:23:01 +0530, Utkarsh Gupta wrote:

> PERL5LIB=/home/utkarsh2102/perl5/lib/perl5
> PERL_LOCAL_LIB_ROOT=/home/utkarsh2102/perl5
> PERL_MB_OPT=--install_base "/home/utkarsh2102/perl5"
> PERL_MM_OPT=INSTALL_BASE=/home/utkarsh2102/perl5

And that exactly explains why perl modules get installed to
/home/utkarsh2102/perl5 in your "normal" enviroment :)

And as there is a PERL_LOCAL_LIB_ROOT variable, this looks very much
like you are after all using local::lib; at least "using" in the
sense of that someone/something sets these variables (maybe in
~/.bashrc or something similar).
Which is fine for using perl modules outside the system installation
but causes grieve when building packages (but that's what chroots are
for anyway).

Ah, I followed the docs for setting things up.
But nevermind, I could perhaps live with it.
Thanks for clearing this up :D


Best,
Utkarsh
Reply | Threaded
Open this post in threaded view
|

Re: RFS: libmoox-shorthas-perl

gregor herrmann-3
On Wed, 12 Jun 2019 20:13:11 +0530, Utkarsh Gupta wrote:

> > And as there is a PERL_LOCAL_LIB_ROOT variable, this looks very much
> > like you are after all using local::lib; at least "using" in the
> > sense of that someone/something sets these variables (maybe in
> > ~/.bashrc or something similar).

> Ah, I followed the docs for setting things up.
> But nevermind, I could perhaps live with it.
> Thanks for clearing this up :D

Out of curiosity: which docs? If this is mentioned in some
debian(-perl) documentation we should add a big warning.


Cheers,
gregor

--
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: The Mamas & The Papas: You Baby

signature.asc (981 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: RFS: libmoox-shorthas-perl

Utkarsh Gupta
Hey,

On Wed, Jun 12, 2019 at 9:49 PM gregor herrmann <[hidden email]> wrote:
Out of curiosity: which docs? If this is mentioned in some
debian(-perl) documentation we should add a big warning.

There was another doc (debian-perl) but can't find that at the moment.
When I do, I'll ping you on IRC.


Best,
Utkarsh