Re: Bug#824449: firefox: FTBFS on sparc64 due to wrong platform definitions

Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Bug#824449: firefox: FTBFS on sparc64 due to wrong platform definitions

John Paul Adrian Glaubitz
Hi!

With Firefox 60.0 ESR now in experimental, most of the sparc64-related patches
are now part of the upstream source.

The only patches we actually need are the one to fix skia on big-endian targets
(I am currently in the process of upstreaming this one) and one tiny patch
to fix an alignment issue on sparc64.

Attaching both of them. The skia patch will also fix the build on s390x.

Adrian

--
  .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [hidden email]
`. `'   Freie Universitaet Berlin - [hidden email]
   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

0001-Bug-1144632-gfx-skia-Fix-skia-build-on-Big-Endian-pl.patch (3K) Download Attachment
0001-Bug-1434726-Early-startup-crash-on-Linux-sparc64-in-.txt (772 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug#824449: firefox: FTBFS on sparc64 due to wrong platform definitions

Mike Hommey
On Fri, May 11, 2018 at 08:49:41PM +0200, John Paul Adrian Glaubitz wrote:
> Hi!
>
> With Firefox 60.0 ESR now in experimental, most of the sparc64-related patches
> are now part of the upstream source.
>
> The only patches we actually need are the one to fix skia on big-endian targets
> (I am currently in the process of upstreaming this one) and one tiny patch
> to fix an alignment issue on sparc64.

For the record, the latter was explicitly rejected.

Mike

Reply | Threaded
Open this post in threaded view
|

Re: Bug#824449: firefox: FTBFS on sparc64 due to wrong platform definitions

John Paul Adrian Glaubitz
On 05/11/2018 11:20 PM, Mike Hommey wrote:
>> The only patches we actually need are the one to fix skia on big-endian targets
>> (I am currently in the process of upstreaming this one) and one tiny patch
>> to fix an alignment issue on sparc64.
>
> For the record, the latter was explicitly rejected.

I know. However, the person who wrote it is a security expert (and a friend of
mine) and I trust him when he says the patch does not change any behavior or
lower the security.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [hidden email]
`. `'   Freie Universitaet Berlin - [hidden email]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Reply | Threaded
Open this post in threaded view
|

Re: Bug#824449: firefox: FTBFS on sparc64 due to wrong platform definitions

John Paul Adrian Glaubitz
In reply to this post by Mike Hommey
Hi!

Both firefox and firefox-esr now build fine on sparc64.

There is still one alignment-related crash though [1], but that should
be addressed in a separate bug report and patch. I'll try to propose
a less intrusive patch upstream.

Adrian

> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1434726

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [hidden email]
`. `'   Freie Universitaet Berlin - [hidden email]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913