Re: Bug#900718: rsyslog: FTBFS on hurd-i386

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Michael Biebl-3
Am 07.06.2018 um 13:37 schrieb Samuel Thibault:
> Michael Biebl, le jeu. 07 juin 2018 13:34:48 +0200, a ecrit:
>> Anyway, such patches should best be sent upstream.
>
> We don't have the manpower to chase all upstream bugtrackers and
> whatnot.

Same is true for me. I don't have the man power to keep maintaining
distro specific patches which belong upstream or playing bug proxy.

Regards,
Michael

--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Samuel Thibault-8
Michael Biebl, le jeu. 07 juin 2018 13:40:45 +0200, a ecrit:
> Am 07.06.2018 um 13:37 schrieb Samuel Thibault:
> > Michael Biebl, le jeu. 07 juin 2018 13:34:48 +0200, a ecrit:
> >> Anyway, such patches should best be sent upstream.
> >
> > We don't have the manpower to chase all upstream bugtrackers and
> > whatnot.
>
> Same is true for me. I don't have the man power to keep maintaining
> distro specific patches which belong upstream or playing bug proxy.

So, does anybody on debian-hurd have time for upstreaming?

Samuel

Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Anatoly A. Kazantsev-3
On Tue, 12 Jun 2018 00:35:15 +0200
Samuel Thibault <[hidden email]> wrote:

> So, does anybody on debian-hurd have time for upstreaming?

I can make a pull request on their github repo.

Should the patch includes some comments?
Can I or should I point to the debian bug report?

--
Regards,
Anatoly

Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Samuel Thibault-8
Anatoly A. Kazantsev, le mar. 12 juin 2018 20:32:25 +1200, a ecrit:
> On Tue, 12 Jun 2018 00:35:15 +0200
> Samuel Thibault <[hidden email]> wrote:
>
> > So, does anybody on debian-hurd have time for upstreaming?
>
> I can make a pull request on their github repo.

Thanks!

> Should the patch includes some comments?
> Can I or should I point to the debian bug report?

I don't know what their habit is. More information is usually always
better than less information.

Samuel

Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Samuel Thibault-8
Also, please remember to run

bts forwarded 900718 http://...

so the Debian BTS knows about the upstream bug report.

Samuel

Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Anatoly A. Kazantsev-3
In reply to this post by Samuel Thibault-8
On Tue, 12 Jun 2018 10:33:20 +0200
Samuel Thibault <[hidden email]> wrote:

> I don't know what their habit is. More information is usually always
> better than less information.

I will go throw their docs, issues and pull request to get the idea.


--
Regards,
Anatoly

Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Samuel Thibault-8
In reply to this post by Samuel Thibault-8
Hello,

Additionally, the attached patch is needed since lsof is non available
on non-linux.

Samuel

patch (454 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Samuel Thibault-8
In reply to this post by Samuel Thibault-8
Hello,

Samuel Thibault, le mar. 12 juin 2018 00:35:15 +0200, a ecrit:

> Michael Biebl, le jeu. 07 juin 2018 13:40:45 +0200, a ecrit:
> > Am 07.06.2018 um 13:37 schrieb Samuel Thibault:
> > > Michael Biebl, le jeu. 07 juin 2018 13:34:48 +0200, a ecrit:
> > >> Anyway, such patches should best be sent upstream.
> > >
> > > We don't have the manpower to chase all upstream bugtrackers and
> > > whatnot.
> >
> > Same is true for me. I don't have the man power to keep maintaining
> > distro specific patches which belong upstream or playing bug proxy.
>
> So, does anybody on debian-hurd have time for upstreaming?
So, can anybody on debian-hurd *please* take some time to have a look at
this?

The more people contribute to this kind of work, the less time I have
to spend on it, the more time I have to spend on more difficult issues
(llvm-toolchain, rustc, php7.3, etc.)

I have attached a refreshed patch.

Samuel

hurd (748 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Michael Biebl-3
In reply to this post by Samuel Thibault-8
Am 04.11.18 um 18:48 schrieb Samuel Thibault:

> Additionally, the attached patch is needed since lsof is non available
> on non-linux.

Is lsof not available at all or just provided by a different package?


--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Samuel Thibault-8
Michael Biebl, le dim. 04 nov. 2018 21:55:58 +0100, a ecrit:
> Am 04.11.18 um 18:48 schrieb Samuel Thibault:
>
> > Additionally, the attached patch is needed since lsof is non available
> > on non-linux.
>
> Is lsof not available at all or just provided by a different package?

It doesn't seem to be provided by any package on Hurd and kFreeBSD.

Samuel

Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Rainer Gerhards
Hi,

Rainer from upstream here. Where is the missing lsof causing issues?
That would probably be the right place to fix. I did a grep over the
testbench and do not see any place where it is required (tests skip
via 77 exit code if not available).

Rainer
El dom., 4 nov. 2018 a las 22:57, Samuel Thibault
(<[hidden email]>) escribiĆ³:

>
> Michael Biebl, le dim. 04 nov. 2018 21:55:58 +0100, a ecrit:
> > Am 04.11.18 um 18:48 schrieb Samuel Thibault:
> >
> > > Additionally, the attached patch is needed since lsof is non available
> > > on non-linux.
> >
> > Is lsof not available at all or just provided by a different package?
>
> It doesn't seem to be provided by any package on Hurd and kFreeBSD.
>
> Samuel
>

Reply | Threaded
Open this post in threaded view
|

Re: Bug#900718: rsyslog: FTBFS on hurd-i386

Michael Biebl-3
Hi Rainer

Am 05.11.18 um 10:43 schrieb Rainer Gerhards:
> Hi,
>
> Rainer from upstream here. Where is the missing lsof causing issues?
> That would probably be the right place to fix. I did a grep over the
> testbench and do not see any place where it is required (tests skip
> via 77 exit code if not available).

The problem is the uninstallability of the lsof package on non-linux
architectures. The result is that a build can not even be tried.
A missing lsof binary is properly handled by the test-suite, which is
why making it conditional on linux-any is fine.

I've committed the proposed patch as

https://salsa.debian.org/debian/rsyslog/commit/0d912206d67fb6cdbc6ad4057686b6ccdf71743f


Michael
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?


signature.asc (849 bytes) Download Attachment