Re: Bug#924329: xastir: FTBFS (magick/image-private.h: No such file or directory)

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Bug#924329: xastir: FTBFS (magick/image-private.h: No such file or directory)

Hibby
Hi all,

I've managed to reproduce this locally, but haven't sat down to properly look at a solution.

As it's an RC bug, it 's worth sorting soon so we're not holding anything up - has anyone got a suggestion of where to start?

Cheers,
DH

--
  Hibby
  [hidden email]
  MM3ZRZ

On Tue, 12 Mar 2019, at 8:03 PM, Andrey Rahmatullin wrote:

> On Mon, Mar 11, 2019 at 05:09:58PM +0000, Santiago Vila wrote:
> > In file included from /usr/include/GraphicsMagick/magick/analyze.h:18,
> >                  from /usr/include/GraphicsMagick/magick/api.h:55,
> >                  from map_geo.c:137:
> > /usr/include/GraphicsMagick/magick/image.h:1108:10: fatal error: magick/image-private.h: No such file or directory
> >  #include "magick/image-private.h"
> >           ^~~~~~~~~~~~~~~~~~~~~~~~
>
>
> src/map_geo.c:
>
> """
> #ifdef HAVE_GRAPHICSMAGICK
> /*#include <GraphicsMagick/magick/api.h>*/
> /* Define MAGICK_IMPLEMENTATION to access private interfaces
>  * such as DestroyImagePixels(). This may not be a good thing,
>  * but DestroyImagePixels() has been in this code for a long
>  * time. Defining MAGIC_IMPLEMENTATION eliminates the warning that is
>  * now (9/28/2010) being seen on some distros (Ubuntu 10.04 and
>  * OpenSuSE-11.3)
>  */
> #define MAGICK_IMPLEMENTATION
> #include <magick/api.h>
> """
>
> Haha NOPE.
>
>
> --
> WBR, wRAR
>
> Attachments:
> * signature.asc

Reply | Threaded
Open this post in threaded view
|

Re: Bug#924329: xastir: FTBFS (magick/image-private.h: No such file or directory)

Christoph Berg-2
Control: tag -1 patch

Re: Hibby 2019-03-29 <[hidden email]>
> Hi all,
>
> I've managed to reproduce this locally, but haven't sat down to properly look at a solution.
>
> As it's an RC bug, it 's worth sorting soon so we're not holding anything up - has anyone got a suggestion of where to start?

Hi,

it looks like simply removing "#define MAGICK_IMPLEMENTATION" from
src/map_geo.c is enough to make it compile for me. I have no clue
about APRS yet, so I can't test it, though.

diff --git a/src/map_geo.c b/src/map_geo.c
index 7547abb..0728161 100644
--- a/src/map_geo.c
+++ b/src/map_geo.c
@@ -133,7 +133,7 @@
  * now (9/28/2010) being seen on some distros (Ubuntu 10.04 and
  * OpenSuSE-11.3)
  */
-#define MAGICK_IMPLEMENTATION
+//#define MAGICK_IMPLEMENTATION
 #include <magick/api.h>
 #else   // HAVE_GRAPHICSMAGICK
 #include <magick/api.h>

Christoph DF7CB

Reply | Threaded
Open this post in threaded view
|

Re: Bug#924329: xastir: FTBFS (magick/image-private.h: No such file or directory)

Christoph Berg-2
On a side note, this looks wrong:

$ cat debian/xastir-data.dirs
usr/share/xastir
usr/share/xastir/config
usr/share/xastir/Counties
usr/share/xastir/fcc
usr/share/xastir/GNIS
usr/share/xastir/help
usr/share/xastir/maps
usr/share/xastir/scripts
usr/share/xatir/sounds
               ^

Christoph

Reply | Threaded
Open this post in threaded view
|

Processed: Re: Bug#924329: xastir: FTBFS (magick/image-private.h: No such file or directory)

Debian Bug Tracking System
In reply to this post by Christoph Berg-2
Processing control commands:

> tag -1 patch
Bug #924329 [src:xastir] xastir: FTBFS (magick/image-private.h: No such file or directory)
Added tag(s) patch.

--
924329: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924329
Debian Bug Tracking System
Contact [hidden email] with problems

Reply | Threaded
Open this post in threaded view
|

Re: Bug#924329: xastir: FTBFS (magick/image-private.h: No such file or directory)

David A Aitcheson
In reply to this post by Christoph Berg-2
Christoph / Hibby,

Pull from Git again as a lot of cleanup happened recently.

In particular the Greek language mess has been backed out of "Master" until it no longer causes rolling font errors.

73
Dave
KB3EFS

PS - Subscribe to
[hidden email] via http://xastir.org/mailman/listinfo/xastir for the latest on the Xastir front.


On 3/31/19 10:57 AM, Christoph Berg wrote:
On a side note, this looks wrong:

$ cat debian/xastir-data.dirs
usr/share/xastir
usr/share/xastir/config
usr/share/xastir/Counties
usr/share/xastir/fcc
usr/share/xastir/GNIS
usr/share/xastir/help
usr/share/xastir/maps
usr/share/xastir/scripts
usr/share/xatir/sounds
               ^

Christoph



Reply | Threaded
Open this post in threaded view
|

Re: Bug#924329: xastir: FTBFS (magick/image-private.h: No such file or directory)

Hibby
Hi Dave,

We might have to backport a patch from git -  at this stage in the freeze I don't think we can pull in new upstream versions, but someone else will need to confirm for me as I'm doubting my own memory - real work is consuming too much brain space currently!

Cheers,
DH

--
  Hibby
  MM3ZRZ


On Mon, 1 Apr 2019, at 2:09 PM, David A Aitcheson wrote:
Christoph / Hibby,

Pull from Git again as a lot of cleanup happened recently.

In particular the Greek language mess has been backed out of "Master" until it no longer causes rolling font errors.

73
Dave
KB3EFS

PS - Subscribe to
[hidden email] via http://xastir.org/mailman/listinfo/xastir for the latest on the Xastir front.


On 3/31/19 10:57 AM, Christoph Berg wrote:
On a side note, this looks wrong:

$ cat debian/xastir-data.dirs
usr/share/xastir
usr/share/xastir/config
usr/share/xastir/Counties
usr/share/xastir/fcc
usr/share/xastir/GNIS
usr/share/xastir/help
usr/share/xastir/maps
usr/share/xastir/scripts
usr/share/xatir/sounds
               ^

Christoph




Reply | Threaded
Open this post in threaded view
|

Re: Bug#924329: xastir: FTBFS (magick/image-private.h: No such file or directory)

Ervin Hegedüs
Hi Hibby, others,

On Mon, Apr 01, 2019 at 09:43:49AM -0400, Hibby wrote:
> Hi Dave,
>
> We might have to backport a patch from git - at this stage in the freeze I don't think we can pull in new upstream versions, but someone else will need to confirm for me as I'm doubting my own memory - real work is consuming too much brain space currently!

the current version of Xastir in testing is 2.1, the patch is
done - so why couldn't we apply the fix? That isn't the new
upstream...

Looks like xastir will removed from testing on 15th of April:

https://tracker.debian.org/pkg/xastir


73, Ervin
HA2OS

Reply | Threaded
Open this post in threaded view
|

Re: Bug#924329: xastir: FTBFS (magick/image-private.h: No such file or directory)

Christoph Berg
Re: Ervin Hegedüs 2019-04-10 <[hidden email]>
> the current version of Xastir in testing is 2.1, the patch is
> done - so why couldn't we apply the fix? That isn't the new
> upstream...
>
> Looks like xastir will removed from testing on 15th of April:

Uploaded my patch now.

Glancing over the package, there's lots of cleanup to do on the
packaging, and generally, the whole package seems horribly old. The
world map even still contains the GDR. I was actually wondering if it
wouldn't be better to remove it, but there are bug reports that sound
like there are actual users.

Christoph

Reply | Threaded
Open this post in threaded view
|

Re: Bug#924329: xastir: FTBFS (magick/image-private.h: No such file or directory)

David Ranch-4

Yes, this codebase is old (uses Motif) but there are quite a large number of users who use Xastir.  More users would use the Debian packages if they were kept up to date more aggressively.

--David
KI6ZHD


On 04/11/2019 03:25 AM, Christoph Berg wrote:
Re: Ervin Hegedüs 2019-04-10 [hidden email]
the current version of Xastir in testing is 2.1, the patch is
done - so why couldn't we apply the fix? That isn't the new
upstream...

Looks like xastir will removed from testing on 15th of April:
Uploaded my patch now.

Glancing over the package, there's lots of cleanup to do on the
packaging, and generally, the whole package seems horribly old. The
world map even still contains the GDR. I was actually wondering if it
wouldn't be better to remove it, but there are bug reports that sound
like there are actual users.

Christoph