Re: Bug#934502: lsb-base: avoid '\r' in logging functions

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Bug#934502: lsb-base: avoid '\r' in logging functions

Thorsten Glaser-6
Hi Dmitry,

> Please, change format to following:

just run:

        sudo sh -c 'echo FANCYTTY=0 >>/etc/lsb-base-logging.sh'

(On the other hand, now that “most” people, and especially the
target group of “fancy” logging, is using systemd instead, perhaps
it’s time to remove the fancy code entirely and go back to the
classical output entirely?)

bye,
//mirabilos
--
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-235
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

**********

Mit der tarent Academy bieten wir auch Trainings und Schulungen in den
Bereichen Softwareentwicklung, Agiles Arbeiten und Zukunftstechnologien an.

Besuchen Sie uns auf www.tarent.de/academy. Wir freuen uns auf Ihren Kontakt.

**********

Reply | Threaded
Open this post in threaded view
|

Re: Bug#934502: lsb-base: avoid '\r' in logging functions

Dmitry Bogatov-3

[2019-08-13 16:48] Thorsten Glaser <[hidden email]>
> > Please, change format to following:
>
> just run:
>
> sudo sh -c 'echo FANCYTTY=0 >>/etc/lsb-base-logging.sh'


> (On the other hand, now that “most” people, and especially the target
> group of “fancy” logging, is using systemd instead, perhaps it’s time
> to remove the fancy code entirely and go back to the classical output
> entirely?)

I support this proposal. Any objections, collegues?
--
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.

Reply | Threaded
Open this post in threaded view
|

Re: Bug#672361: Bug#934502: lsb-base: avoid '\r' in logging functions

Vincent Lefevre-10
On 2019-08-14 19:21:01 +0000, Dmitry Bogatov wrote:

> [2019-08-13 16:48] Thorsten Glaser <[hidden email]>
> > > Please, change format to following:
> >
> > just run:
> >
> > sudo sh -c 'echo FANCYTTY=0 >>/etc/lsb-base-logging.sh'
>
>
> > (On the other hand, now that “most” people, and especially the target
> > group of “fancy” logging, is using systemd instead, perhaps it’s time
> > to remove the fancy code entirely and go back to the classical output
> > entirely?)
>
> I support this proposal. Any objections, collegues?

I think that there are no big issues with colors (all terminals and
"less" can handle them) and they can be useful to see failures more
easily. Thus I think that they shoud be kept.

/lib/lsb/init-functions.d/20-left-info-blocks is what should be
dropped actually since it involves cursor movements and is not
much useful. Moreover, the output can be wrong when the program
outputs warnings or error messages.

Then bootlogd should not do any filtering.

--
Vincent Lefèvre <[hidden email]> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)