Re: [Debian-med-packaging] Bug#884795: Bug#884795: patman: FTBFS on x32: final link failed: Nonrepresentable section

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Debian-med-packaging] Bug#884795: Bug#884795: patman: FTBFS on x32: final link failed: Nonrepresentable section

Graham Inggs-3
Hi Aaron

On 19 December 2017 at 21:30, Graham Inggs <[hidden email]> wrote:
> Fixed in git:
> https://anonscm.debian.org/cgit/debian-med/patman.git/commit/?id=9e677022c3c9f3038a738efaa42fa8541fe3b8f6

So this worked, and a similar fix worked in motif [1].
I feel this is merely a workaround for the actual problem.

Should PIE be enabled by default for X32?
Should "DEB_BUILD_MAINT_OPTIONS=hardening=+all" not include PIE on
architectures where it is not enabled by default?

I have no idea where to start; X32 porters?  gcc maintainers?  dpkg maintainers?

Any suggestions would be welcome.

Regards
Graham


[1] https://anonscm.debian.org/cgit/collab-maint/motif.git/commit/?id=27d0d5d3a59c6ebf2fc99e04a687c73a45d9eb44

Reply | Threaded
Open this post in threaded view
|

Re: [Debian-med-packaging] Bug#884795: Bug#884795: patman: FTBFS on x32: final link failed: Nonrepresentable section

Aaron M. Ucko
Graham Inggs <[hidden email]> writes:

>> Fixed in git:

Thanks!

> Any suggestions would be welcome.

I haven't looked at motif's build system, but I see that patman's
makefile doesn't honor CFLAGS or CXXFLAGS (which would be the normal
means of injecting relevant flags here), just CPPFLAGS (which is
supposed to be for the C PreProcessor).  It should properly consult both
CPPFLAGS and CXXFLAGS, and distribute its own flags across these two
variables as appropriate.

--
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?amu@...

Reply | Threaded
Open this post in threaded view
|

Re: [Debian-med-packaging] Bug#884795: Bug#884795: patman: FTBFS on x32: final link failed: Nonrepresentable section

Graham Inggs-3
On 20/12/2017 20:00, Aaron M. Ucko wrote:
> I haven't looked at motif's build system, but I see that patman's
> makefile doesn't honor CFLAGS or CXXFLAGS (which would be the normal
> means of injecting relevant flags here), just CPPFLAGS (which is
> supposed to be for the C PreProcessor).  It should properly consult both
> CPPFLAGS and CXXFLAGS, and distribute its own flags across these two
> variables as appropriate.

Thanks for that tip!  It seems upstream had CPPFLAGS and CXXFLAGS
confused.  Correcting that [1] made blhc happy, and I was able to revert
my previous workaround.

Andreas, ping me if you want that uploaded.

As far as I can tell, hardening flags are being passed correctly in
motif though.


[1]
https://anonscm.debian.org/cgit/debian-med/patman.git/commit/?id=3e830b572446d24e7163cb183d30e2ce402976bb