Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 2 commits: Adjust sbin/debian-edu-pxeinstall

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 2 commits: Adjust sbin/debian-edu-pxeinstall

Holger Levsen-2
Hi Wolfgang,

On Mon, Mar 18, 2019 at 02:43:43PM +0000, WolfgangSchweer wrote:
> 02f4c2cf by Wolfgang Schweer at 2019-03-18T14:39:22Z
[...]
> Replace code to determine the distribution so that it also works offline.

refers to the following change, I believe:

> -[ "$dist" ]       || dist=$(lsb_release -sc)
> +[ "$dist" ]       || dist=$(cat /etc/debian_version | cut -d'/' -f1)

why doesn't the former work offline?

is that maybe a bug in lsb_release (which we could work around like the
above, but then we should probably file a bug so it gets fixed properly
eventually...) ?


--
tschau,
        Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 2 commits: Adjust sbin/debian-edu-pxeinstall

Wolfgang Schweer-3
On Wed, Mar 20, 2019 at 11:09:05AM +0000, Holger Levsen wrote:
> On Mon, Mar 18, 2019 at 02:43:43PM +0000, WolfgangSchweer wrote:
> > 02f4c2cf by Wolfgang Schweer at 2019-03-18T14:39:22Z
> [...]
> > Replace code to determine the distribution so that it also works offline.
>
> refers to the following change, I believe:

yes.
 
> > -[ "$dist" ]       || dist=$(lsb_release -sc)
> > +[ "$dist" ]       || dist=$(cat /etc/debian_version | cut -d'/' -f1)
>
> why doesn't the former work offline?

It used to do so (at least in Stretch). The same change has been needed
for LTSP as well. It might be related to different information now on
the BD...
 
> is that maybe a bug in lsb_release (which we could work around like the
> above, but then we should probably file a bug so it gets fixed properly
> eventually...) ?

I rather suspect a different BD behaviour (compared to a.s.n builds),
but not really sure about it.
lsb_release works quite ok if the Release information is fetched from
the web. Needs more investigation...

Wolfgang

signature.asc (981 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 2 commits: Adjust sbin/debian-edu-pxeinstall

Wolfgang Schweer-3
On Wed, Mar 20, 2019 at 01:09:43PM +0100, Wolfgang Schweer wrote:
> I rather suspect a different BD behaviour (compared to a.s.n builds),
> but not really sure about it.
> lsb_release works quite ok if the Release information is fetched from
> the web. Needs more investigation...
 
See a related case:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696332

Wolfgang

signature.asc (981 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 2 commits: Adjust sbin/debian-edu-pxeinstall

Holger Levsen-2
On Wed, Mar 20, 2019 at 01:24:23PM +0100, Wolfgang Schweer wrote:
> On Wed, Mar 20, 2019 at 01:09:43PM +0100, Wolfgang Schweer wrote:
> > I rather suspect a different BD behaviour (compared to a.s.n builds),
> > but not really sure about it.
> > lsb_release works quite ok if the Release information is fetched from
> > the web. Needs more investigation...
> See a related case:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696332

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696332#31 seems to
describe the cause for the BD case.

I'd suggest to reword d/changelog (not to mention offline..) and maybe to refer
to that bug...


--
tschau,
        Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 2 commits: Adjust sbin/debian-edu-pxeinstall

Wolfgang Schweer-3
On Wed, Mar 20, 2019 at 03:54:42PM +0000, Holger Levsen wrote:

> On Wed, Mar 20, 2019 at 01:24:23PM +0100, Wolfgang Schweer wrote:
> > On Wed, Mar 20, 2019 at 01:09:43PM +0100, Wolfgang Schweer wrote:
> > > I rather suspect a different BD behaviour (compared to a.s.n builds),
> > > but not really sure about it.
> > > lsb_release works quite ok if the Release information is fetched from
> > > the web. Needs more investigation...
> > See a related case:
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696332
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696332#31 seems to
> describe the cause for the BD case.
Saw that, too. But I wasn't able to reproduce it for the BD case.
 
> I'd suggest to reword d/changelog (not to mention offline..) and maybe to refer
> to that bug...

IMO the BD description (snapshot, not release) is the culprit.

Feel free to drop the offline part from the reworded changlog entry.

Wolfgang

signature.asc (981 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 2 commits: Adjust sbin/debian-edu-pxeinstall

Wolfgang Schweer-3
In reply to this post by Holger Levsen-2
On Wed, Mar 20, 2019 at 11:09:05AM +0000, Holger Levsen wrote:
> On Mon, Mar 18, 2019 at 02:43:43PM +0000, WolfgangSchweer wrote:
> > 02f4c2cf by Wolfgang Schweer at 2019-03-18T14:39:22Z
> [...]
> > Replace code to determine the distribution so that it also works offline.
>
> refers to the following change, I believe:
>
> > -[ "$dist" ]       || dist=$(lsb_release -sc)
> > +[ "$dist" ]       || dist=$(cat /etc/debian_version | cut -d'/' -f1)
 
After lots of digging into it I found out that this change is actually a
bad idea: while debian_version contains text in case of testing or
unstable, it contains only the version number (like 9.8). I reverted
this change.

Thanks to Holger for the review.

Wolfgang

signature.asc (981 bytes) Download Attachment