Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 5 commits: Drop share/debian-edu-config/tools/password-fix-squeeze-r0.

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 5 commits: Drop share/debian-edu-config/tools/password-fix-squeeze-r0.

Wolfgang Schweer-3
On Tue, Oct 08, 2019 at 11:46:29AM +0000, Holger Levsen wrote:
> - - - - -
> 57c755df by Holger Levsen at 2019-10-08T11:37:12Z
> rewrite another comment to not cause confusion when looking for cruft, or should we drop this script completly?

The ldap-debian-edu-install script is needed during main server installation...

Wolfgang

signature.asc (981 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 5 commits: Drop share/debian-edu-config/tools/password-fix-squeeze-r0.

Holger Levsen-2
On Wed, Oct 09, 2019 at 12:17:11AM +0200, Wolfgang Schweer wrote:
> On Tue, Oct 08, 2019 at 11:46:29AM +0000, Holger Levsen wrote:
> > - - - - -
> > 57c755df by Holger Levsen at 2019-10-08T11:37:12Z
> > rewrite another comment to not cause confusion when looking for cruft, or should we drop this script completly?
> The ldap-debian-edu-install script is needed during main server installation...

ic. I didnt expect this from the look of it :/ we should probably clean
it up a bit, eg commented out code and update comments.

And the header should probably also say that. Right now the commends
made me think this is ment to be run manually...


--
cheers,
        Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 5 commits: Drop share/debian-edu-config/tools/password-fix-squeeze-r0.

Wolfgang Schweer-3
On Tue, Oct 08, 2019 at 10:35:41PM +0000, Holger Levsen wrote:
> On Wed, Oct 09, 2019 at 12:17:11AM +0200, Wolfgang Schweer wrote:
> > On Tue, Oct 08, 2019 at 11:46:29AM +0000, Holger Levsen wrote:
> > > - - - - -
> > > 57c755df by Holger Levsen at 2019-10-08T11:37:12Z
> > > rewrite another comment to not cause confusion when looking for cruft, or should we drop this script completly?
> > The ldap-debian-edu-install script is needed during main server installation...
>
> ic. I didnt expect this from the look of it :/ we should probably clean
> it up a bit, eg commented out code and update comments.

Done so, please check.

Wolfgang

signature.asc (981 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 5 commits: Drop share/debian-edu-config/tools/password-fix-squeeze-r0.

Holger Levsen-2
Hi Wolfgang,

On Wed, Oct 09, 2019 at 11:39:43PM +1300, Wolfgang Schweer wrote:
> > ic. I didnt expect this from the look of it :/ we should probably clean
> > it up a bit, eg commented out code and update comments.
> Done so, please check.

looks good to me, thank you very much!

just one question: in share/debian-edu-config/passwords_stub.dat
you changed the (password) value from skolelinux to an empty string, I
guess that's very much intended by you? :)

(As usual I'll wait with uploading these changes until the current d-e-c
version in unstable migrated to bullseye.)

--
cheers,
        Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 5 commits: Drop share/debian-edu-config/tools/password-fix-squeeze-r0.

Wolfgang Schweer-3


Am October 9, 2019 12:18:56 PM UTC schrieb Holger Levsen <[hidden email]>:
>just one question: in share/debian-edu-config/passwords_stub.dat
>you changed the (password) value from skolelinux to an empty string, I
>guess that's very much intended by you? :)

Yes, intended. The password isn't used when recreating the LDAP data base, not cleared from debconf either and would be sitting there forever which should be avoided. The icinga2-classicui  is added though for the sake of completeness (same entries like before LDAP recreation). Feel free to add this change to d/changelog...

Wolfgang

(sent from mobile device)

Reply | Threaded
Open this post in threaded view
|

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 5 commits: Drop share/debian-edu-config/tools/password-fix-squeeze-r0.

Holger Levsen-2
On Wed, Oct 09, 2019 at 10:51:15PM +0000, Wolfgang Schweer wrote:
> Yes, intended.

thanks for explaining. I think the d/changelog entry is fine.


--
cheers,
        Holger

-------------------------------------------------------------------------------
               holger@(debian|reproducible-builds|layer-acht).org
       PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C


signature.asc (849 bytes) Download Attachment