Re: dump1090 in Debian

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Iain R. Learmonth-2
Hi Matthew,

On Thu, Oct 16, 2014 at 04:14:40PM -0700, Matthew Ernisse wrote:
> I currently have a package on mentors.d.n that is more or less complete.
> It builds and I have been feeding FlightAware with it for a month or so
> now. I need to pull the latest git version of dump1090 and update it, and
> then would need sponsorship. Any help getting through the sponsorship
> process or just eyes on the package would be greatly appreciated.

Ok. The first step to joining the Hamradio Maintainers Team is to sign up
for an Alioth account if you haven't already got one. You can do this here:

  https://alioth.debian.org/account/register.php

Once you've done that, send me your username and I'll add you to the team.
You can then import your packaging work into our git which makes it easier
for us to help you with the package. Instructions for that are at:

  https://wiki.debian.org/DebianHams/Git

I've taken a brief look at the package and I've got a few comments. Please
feel free to ask if there are any you don't understand.

coaa1090.obj - There is no source code for this file. I see you've added a
lintian override but ftp-master will *not* accept this. You have a few
options here:

 * Try to locate the source, include it in a directory under debian/ and add
   a README.source explaining how that file is built from the source you've
   added.
 * If the file isn't necessary for the build, do a DFSG repack of the
   upstream tarball.
 * If the file isn't necessary for the build, contact the upstream author
   and ask them to remove it from their tarball.

privacy-breach-generic - Again, I see you've added lintian overrides here,
but again, ftp-master will *not* accept this. For jquery, you can depend on
the libjs-jquery-ui package and then create symlinks from the CSS and JS
files installed by that package to usr/share/dump1090/public_html/ and then
patch gmap.html. It may be that there's nothing you can do with the Google
Maps JS as that doesn't appear to be open source and you end up contacting
the Google server for map tiles anyway so maybe an override would be
acceptable for that one.

watch file - Have you tried to contact upstream to ask them if they are
willing to tag releases? If they are, brilliant! You can them update the
watch file. If not, delete the watch file. If one is present things will try
to run it and they will throw up errors even if it doesn't contain anything.

Vcs-Browser and Vcs-Git - These fields are intended to point to where the
packaging work is being done, so these should be changed to point to the
Debian Hamradio Maintainers git as explained in the DebianHams/Git wiki page
linked above.

Maintainer - For team packages, the maintainer and upload lines should be:

------------------------------------------------------------------------
Maintainer: Debian Hamradio Maintainers <[hidden email]>
Uploaders: Your Name <your@email>
------------------------------------------------------------------------

This allows us to more easily keep track of the packages that are being
looked after within the team.

Standards version - The current standards version is 3.9.6. You can safely
bump this as I don't believe any of the changes made will affect your
package between 3.9.5 and the current version.

Copyright - In the copyright file, you've used GPL-2.0+ which should be
GPL-2 and BSD-2-Clause which should be BSD-2-clause. You can see the
shortcodes that are defined here:

  http://dep.debian.net/deps/dep5/#license-specification

Other than that, the copyright file looks good.

Control file - Is the dependency on dpkg-dev really needed? The priority for
the package should be "optional" not "extra". "extra" is more for things
like debugging symbols for applications than applications themselves. Also
the Maintainer and Vcs things mentioned above.

It does look like you've got the basis of a good package. Once I'm happy
that the package is ready, I will arrange to have a DD sponsor it and get it
uploaded to the archives.

Thanks for your work on this package.

Iain.

--
e: [hidden email]            w: iain.learmonth.me
x: [hidden email]     t: +447875886930
c: MM6MVQ                  g: IO87we
p: 1F72 607C 5FF2 CCD5 3F01 600D 56FF 9EA4 E984 6C49

attachment0 (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Iain R. Learmonth-2
On Tue, Oct 21, 2014 at 11:03:27AM -0400, Matthew Ernisse wrote:
> Done, my username is mernisse-guest.

I've added you to the team, so you will now have access to create a git
repository and import your work.

> I opted for the DFSG repack.  The blob comes from the PlanePlotter folks
> and is completely proprietary.

This sounds good.

> So this is becoming a headache.  I patched dump1090 to enable locally-hosting
> jQuery but it opens the sockets with O_NONBLOCK and has a very primitive loop
> for handling all network traffic.  Sometimes when transmitting jQuery send(2)
> throws back EWOULDBLOCK and drops the connection.  I'm not 100% sure what the
> 'right' fix is here.  I'm tempted to split the web UI out into a separate
> package and just drop it in as a site for lighttpd/apache.  I'd welcome some
> thoughts on that.

If it's running the web interface locally, can you just do a link to
"file:///usr/share/javascript/jquery-ui/jquery-ui.min.js" and not even
bother serving it over HTTP? It is an interesting problem though.

If it needs to be over HTTP, you could try asking in #debian-mentors on
irc.debian.org. I've not had this problem myself, but someone will have, and
there should be a way of dealing with it.

> I've deleted the watch file for now.  I have asked upstream about tagging
> releases but have yet to hear back.

As long as the watch file is gone, it won't be throwing up errors. They're
not mandatory for the package, but it is useful to be able to know when new
releases happen automatically.

> > Control file - Is the dependency on dpkg-dev really needed?
> I had it becuase lintian(8) throws a warning during debuild about it, but
> as far as I can tell it isn't *actually* needed.

So I've just checked, and debhelper does depend on dpkg-dev, so it's not
needed as far as I can see.

> That's good news.  The new version of the package is up on mentors.d.n and
> tagged in github.com/mernisse/dump1090.  I'll move it over to the hamradio git
> once I have access.

I'm busy tonight, but I'll take a look at the package tomorrow and let you
know if I have any comments.

Thanks,
Iain.

--
e: [hidden email]            w: iain.learmonth.me
x: [hidden email]     t: +447875886930
c: MM6MVQ                  g: IO87we
p: 1F72 607C 5FF2 CCD5 3F01 600D 56FF 9EA4 E984 6C49

attachment0 (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Matthew Ernisse
In reply to this post by Iain R. Learmonth-2
On Tue, Oct 21, 2014 at 06:30:10PM +0100, Iain R. Learmonth said unto me:
> I've added you to the team, so you will now have access to create a git
> repository and import your work.

I committed the packaging work to pkg-hamradio/dump1090.  I started tagging
versions, 1.09.1007.14+dfsg-6 is current.  It is also up on mentors, but
for some reason the latest lintian runs there have been complaining about
no compat version set but debian/compat contains '9'.

> If it needs to be over HTTP, you could try asking in #debian-mentors on
> irc.debian.org. I've not had this problem myself, but someone will have, and
> there should be a way of dealing with it.

I sent some messages to [hidden email].  I decided to Suggest:
apache and provide instructions and examples to implement the web interface.
It has been working on my RPi just fine for a few days now.  I also took
the opportunity to disable filesystem access in the internal HTTP so there
is less of a security concern.

> I'm busy tonight, but I'll take a look at the package tomorrow and let you
> know if I have any comments.

No worries.  I'm fairly happy with the current state of the package.  I'm
starting to put together a branch of changes to merge back to upstream.
I'm travelling for work next week so I may not be able to make changes
until I get back, so no rush.

--Matt

--
Matthew Ernisse
E-Mail: [hidden email]
Web: http://www.ub3rgeek.net/                   PGP Key ID: 0x4AE6BF32

signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Iain R. Learmonth-2
Hi Matthew,

(Please let me know if you're subscribed to the list so I can stop CC'ing
you.)

On Thu, Oct 23, 2014 at 12:51:02PM -0400, Matthew Ernisse wrote:
> I committed the packaging work to pkg-hamradio/dump1090.  I started tagging
> versions, 1.09.1007.14+dfsg-6 is current.  It is also up on mentors, but
> for some reason the latest lintian runs there have been complaining about
> no compat version set but debian/compat contains '9'.

I don't seem to be able to build a package from your git repository. For
git-buildpackage to work it requires a certain structure. Also, the first
version into the Debian archives should be -1. I know there will be
revisions as you build packages, but the Debian revision number should only
be incremented when a new version is uploaded to the archives.

I would suggest moving your debian/ directory somewhere safe, creating a new
git repository, then:

git import-orig --pristine-tar <your-dsfg-repack>.tar.gz

Then move the debian/ directory back, add it and commit it. This will create
the upstream and pristine-tar branches for you, which will allow people to
recreate the orig.tar.gz from the git repository and use git-buildpackage
(and therefore git-pbuilder).

You'll need to allow non-fast-forwards to the git on alioth to push this.
I've noticed I messed up with the setup-repository script and as a result,
you are the only person able to access the git repository. Could you run on
alioth:

chgrp scm_pkg-hamradio -R /git/pkg-hamradio/dump1090.git

In the file /git/pkg-hamradio/dump1090.git/config, just comment out the line
that denies non-fast-forwards when you push --force and then uncomment it
again once you have.

git remote add origin git+ssh://alioth.debian.org/git/pkg-hamradio/dump1090.git
git push --force --all
git push --force --tags

If you know more git than I do, you may know of a more elegant way of doing
this, but that's what I would do.

> I sent some messages to [hidden email].  I decided to Suggest:
> apache and provide instructions and examples to implement the web interface.
> It has been working on my RPi just fine for a few days now.  I also took
> the opportunity to disable filesystem access in the internal HTTP so there
> is less of a security concern.

This sounds like a good way to go with this. A dependency on apache would be
too much, but a suggest sounds good.

> No worries.  I'm fairly happy with the current state of the package.  I'm
> starting to put together a branch of changes to merge back to upstream.
> I'm travelling for work next week so I may not be able to make changes
> until I get back, so no rush.

Pushing changes to upstream is good. Have you had any luck with contacting
upstream yet?

Thanks,
Iain.

--
e: [hidden email]            w: iain.learmonth.me
x: [hidden email]     t: +447875886930
c: MM6MVQ                  g: IO87we
p: 1F72 607C 5FF2 CCD5 3F01 600D 56FF 9EA4 E984 6C49

attachment0 (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Matthew Ernisse
Good Morning Iain,

On Fri, Oct 24, 2014 at 01:51:26AM +0100, Iain R. Learmonth said unto me:
> (Please let me know if you're subscribed to the list so I can stop CC'ing
> you.)

I am now.

> I don't seem to be able to build a package from your git repository. For
> git-buildpackage to work it requires a certain structure. Also, the first
> version into the Debian archives should be -1. I know there will be
> revisions as you build packages, but the Debian revision number should only
> be incremented when a new version is uploaded to the archives.

I rebuilt the git repository as you suggested and pushed it up over my
previous work.  I also compressed the debian/changelog entries so we are
back to just -1.

> chgrp scm_pkg-hamradio -R /git/pkg-hamradio/dump1090.git

Done.

> Pushing changes to upstream is good. Have you had any luck with contacting
> upstream yet?

I have not heard anything back from the e-mail address in the source so I
went ahead and backported a bunch of patches into a branch on github last
night and submitted a pull request.  He seems to be fairly active on
github so I have some hope of a response.

--Matt

--
Matthew Ernisse
E-Mail: [hidden email]
Web: http://www.ub3rgeek.net/                   PGP Key ID: 0x4AE6BF32

signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Iain R. Learmonth-2
On Fri, Oct 24, 2014 at 09:56:16AM -0400, Matthew Ernisse wrote:
> I rebuilt the git repository as you suggested and pushed it up over my
> previous work.  I also compressed the debian/changelog entries so we are
> back to just -1.

This all looks good. I can confirm it builds for me using git-pbuilder so
you've got all the build dependencies correct.

Lintian does make complaints regarding d/copyright.

I: dump1090 source: wildcard-matches-nothing-in-dep5-copyright
rtl-sdr/rtl-sdr_export.c (paragraph at line 39)
I: dump1090 source: wildcard-matches-nothing-in-dep5-copyright
rtl-sdr/rtl-sdr.h (paragraph at line 43)
I: dump1090 source: unused-file-paragraph-in-dep5-copyright paragraph at
line 39
I: dump1090 source: unused-file-paragraph-in-dep5-copyright paragraph at
line 43

I've also noticed two more files that may need to be fixed for the DFSG
repack.

 * dump1090-win.1.09.0608.14.zip - definitely needs to be removed
 * testfiles/modes1.bin - no idea what this is, if it's a dump of ADS-B data
   used as part of a test suite, then that's fine. If it's a binary
   containing executable code, then source will need to be included.

The closing of the ITP bug should happen in the first release that enters
Debian, so you'll need to move that in the changelog.

Once these things are fixed, I'll take an in depth look for any last things
and then pass it on to Colin who, if he doesn't find any problems, will be
able to sponsor the upload.

Thanks,
Iain.

--
e: [hidden email]            w: iain.learmonth.me
x: [hidden email]     t: +447875886930
c: MM6MVQ                  g: IO87we
p: 1F72 607C 5FF2 CCD5 3F01 600D 56FF 9EA4 E984 6C49

attachment0 (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Matthew Ernisse
On Fri, Oct 24, 2014 at 08:10:29PM +0100, Iain R. Learmonth said unto me:
> This all looks good. I can confirm it builds for me using git-pbuilder so
> you've got all the build dependencies correct.

Excellent.

> Lintian does make complaints regarding d/copyright.

Fixed.

> I've also noticed two more files that may need to be fixed for the DFSG
> repack.
>
>  * dump1090-win.1.09.0608.14.zip - definitely needs to be removed

Removed.

>  * testfiles/modes1.bin - no idea what this is, if it's a dump of ADS-B data
>    used as part of a test suite, then that's fine. If it's a binary
>    containing executable code, then source will need to be included.

This is a raw data capture off the RTL-SDR stick for testing dump1090
without having the USB device present.  It is referenced in README.md.

> The closing of the ITP bug should happen in the first release that enters
> Debian, so you'll need to move that in the changelog.

Done.

> Once these things are fixed, I'll take an in depth look for any last things
> and then pass it on to Colin who, if he doesn't find any problems, will be
> able to sponsor the upload.

I appreciate all the help.  Hopefully there isn't too much left to do.

--Matt

--
Matthew Ernisse
E-Mail: [hidden email]
Web: http://www.ub3rgeek.net/                   PGP Key ID: 0x4AE6BF32

signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Iain R. Learmonth-2
Hi Matthew,

This all looks good. I think my only issue now is that the d/copyright file is
a bit complicated. Lots of entries that could be combined into single entries.

Take a look at the patch I've attached and see if you think it makes things
simpler (whilst still being accurate).

If you're happy with the patch, apply it, push the git and upload a package to
mentors.d.o. We can then look at uploading to unstable.

Thanks,
Iain.

--
e: [hidden email]            w: iain.learmonth.me
x: [hidden email]     t: +447875886930
c: MM6MVQ                  g: IO87we
p: 1F72 607C 5FF2 CCD5 3F01 600D 56FF 9EA4 E984 6C49


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: https://lists.debian.org/1415095808-22120-1-git-send-email-irl@...

Reply | Threaded
Open this post in threaded view
|

[PATCH] Simplified d/copyright by combining entries with the same license

Iain R. Learmonth-2
---
 debian/copyright | 31 ++++---------------------------
 1 file changed, 4 insertions(+), 27 deletions(-)

diff --git a/debian/copyright b/debian/copyright
index 2252d73..2eeeace 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,34 +1,15 @@
 Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: dump1090
-Source: git clone https://github.com/MalcolmRobb/dump1090
+Source: https://github.com/MalcolmRobb/dump1090
 
 Files: *
-Copyright: 2012 Salvatore Sanfilippo <[hidden email]>
-           2014 Malcolm Robb <[hidden email]>
-License: BSD-3-clause
-
-Files: anet.*
 Copyright: 2006-2012 Salvatore Sanfilippo <[hidden email]>
+           2014 Malcolm Robb <[hidden email]>
 License: BSD-3-clause
 
-Files: dump1090.*
-Copyright: 2012 Salvatore Sanfilippo <[hidden email]>
-License: BSD-2-clause
-
-Files: interactive.*
-Copyright: 2012 Salvatore Sanfilippo <[hidden email]>
-License: BSD-2-clause
-
-Files: mode_ac.*
-Copyright: 2012 Salvatore Sanfilippo <[hidden email]>
-License: BSD-2-clause
-
-Files: net_io.*
+Files: dump1090.* interactive.* mode_ac.* net_io.* ppup1090.* view1090.*
 Copyright: 2012 Salvatore Sanfilippo <[hidden email]>
-License: BSD-2-clause
-
-Files: ppup1090.*
-Copyright: 2013 Malcolm Robb <[hidden email]>
+           2013-2014 Malcolm Robb <[hidden email]>
 License: BSD-2-clause
 
 Files: pthreads/*
@@ -45,10 +26,6 @@ Copyright: 2012 Steve Markgraf <[hidden email]>
            2012 Dimitri Stolnikov <[hidden email]>
 License: GPL-2.0
 
-Files: view1090.*
-Copyright: 2014 Malcolm Robb <[hidden email]>
-License: BSD-2-clause
-
 Files: debian/*
 Copyright: 2014 Matthew Ernisse <[hidden email]>
 License: BSD-2-clause
--
2.1.1


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: https://lists.debian.org/1415095808-22120-2-git-send-email-irl@...

Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Matthew Ernisse
In reply to this post by Iain R. Learmonth-2
On Tue, Nov 04, 2014 at 10:10:07AM +0000, Iain R. Learmonth said unto me:
> > This all looks good. I think my only issue now is that the
> d/copyright file is a bit complicated.

[ snip ]

> Take a look at the patch I've attached and see if you think it makes
> things simpler (whilst still being accurate).

Looks good to me.  I also updated to the latest upstream revision so I
had to port over a few patches as some things have changed.  The new
build should be up on mentors.d.n shortly.

--Matt

--
Matthew Ernisse
E-Mail: [hidden email]
Web: http://www.ub3rgeek.net/                   PGP Key ID: 0x4AE6BF32

signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

dump1090 in Debian

Iain R. Learmonth-2
Hi Colin,

Hopefully you're back to operational now after the GRUB issues.

Matthew Ernisse has been working on a package for dump1090 as you've
probably seen on the list and I think it looks about ready for upload.

Could you take a look at the package at [1] and give feedback via the list?

[1]: http://mentors.debian.net/package/dump1090

If you're not yet back up and running, please let us know so we can throw
out an RFS to the list.

Thanks,
Iain.

--
e: [hidden email]            w: iain.learmonth.me
x: [hidden email]     t: +447875886930
c: MM6MVQ                  g: IO87we
p: 1F72 607C 5FF2 CCD5 3F01 600D 56FF 9EA4 E984 6C49

attachment0 (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

David A Aitcheson
Ian,

Once 'dump1090' gets sponsored in Debian I think it should be pushed into Ubuntu as well.

Is there anything special that needs to be done such as setting up a PPA in Launchpad and the few minor tweeks that any package needs?

73
Dave
KB3EFS

PS - Kamal, any thoughts, or are you already overloaded?


On 11/04/14 22:16, Iain R. Learmonth wrote:
Hi Colin,

Hopefully you're back to operational now after the GRUB issues.

Matthew Ernisse has been working on a package for dump1090 as you've
probably seen on the list and I think it looks about ready for upload.

Could you take a look at the package at [1] and give feedback via the list?

[1]: http://mentors.debian.net/package/dump1090

If you're not yet back up and running, please let us know so we can throw
out an RFS to the list.

Thanks,
Iain.


--
David A Aitcheson [hidden email] Go Green! Print this email only when necessary.
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Colin Tuckley-2
In reply to this post by Iain R. Learmonth-2
On 05/11/14 03:16, Iain R. Learmonth wrote:

> Hopefully you're back to operational now after the GRUB issues.

Yes, however I've been otherwise busy

> Matthew Ernisse has been working on a package for dump1090 as
> you've probably seen on the list and I think it looks about ready
> for upload.

We are now so close to the freeze date that there is no chance of a
new package getting in. So it's normally considered good practice to
*not* upload things which would make more work for the various teams
involved in the release.

> Could you take a look at the package at [1] and give feedback via
> the list?

I'll try to find the time.

Colin

--
Colin Tuckley      |  +44(0)1223 830814  |  PGP/GnuPG Key Id
Debian Developer   |  +44(0)7799 143369  |     0x38C9D903


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: https://lists.debian.org/5459E3EC.1000200@...

Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Iain R. Learmonth-2
In reply to this post by David A Aitcheson
Hi David,

On Wed, Nov 05, 2014 at 02:05:57AM -0500, David A Aitcheson wrote:
> Once 'dump1090' gets sponsored in Debian I think it should be pushed
> into Ubuntu as well.

Ubuntu take a scrape of unstable every six months and use that as a basis
for the next Ubuntu release, so it will enter Ubuntu automatically.

Iain.

--
e: [hidden email]            w: iain.learmonth.me
x: [hidden email]     t: +447875886930
c: MM6MVQ                  g: IO87we
p: 1F72 607C 5FF2 CCD5 3F01 600D 56FF 9EA4 E984 6C49

attachment0 (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: dump1090 in Debian

Iain R. Learmonth-2
In reply to this post by Colin Tuckley-2
Hi Colin,

On Wed, Nov 05, 2014 at 08:46:36AM +0000, Colin Tuckley wrote:
> We are now so close to the freeze date that there is no chance of a
> new package getting in. So it's normally considered good practice to
> *not* upload things which would make more work for the various teams
> involved in the release.

Ah yes, I've not been around Debian during a freeze before so I'm still
learning how the process works.

> I'll try to find the time.

Cool, thanks. Obviously with uploads being a bad idea just now, there's no
rush.

Thanks,
Iain.

--
e: [hidden email]            w: iain.learmonth.me
x: [hidden email]     t: +447875886930
c: MM6MVQ                  g: IO87we
p: 1F72 607C 5FF2 CCD5 3F01 600D 56FF 9EA4 E984 6C49

attachment0 (836 bytes) Download Attachment