Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Charles Plessy-12
> -  <section id="s-3.9.8.0">
> -    <title>Version 3.9.8.0</title>
> +  <section id="s-3.9.8">
> +    <title>Version 3.9.8</title>
>  
>      <para>
>        Released April, 2016.
> @@ -318,8 +329,8 @@
>      </variablelist>
>    </section>
>  
> -  <section id="s-3.9.7.0">
> -    <title>Version 3.9.7.0</title>
> +  <section id="s-3.9.7">
> +    <title>Version 3.9.7</title>

Hello everybody,

isn't there a risk to break links with that change ?

Have a nice day,

[Please CC me, I have not resubscribed yet.]

--
Charles

Reply | Threaded
Open this post in threaded view
|

Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Russ Allbery-2
Charles Plessy <[hidden email]> writes:

>> -  <section id="s-3.9.8.0">
>> -    <title>Version 3.9.8.0</title>
>> +  <section id="s-3.9.8">
>> +    <title>Version 3.9.8</title>
>>  
>>      <para>
>>        Released April, 2016.
>> @@ -318,8 +329,8 @@
>>      </variablelist>
>>    </section>
>>  
>> -  <section id="s-3.9.7.0">
>> -    <title>Version 3.9.7.0</title>
>> +  <section id="s-3.9.7">
>> +    <title>Version 3.9.7</title>

> Hello everybody,

> isn't there a risk to break links with that change ?

The DocBook conversion already broke any links to upgrading-checklist
sections, unfortunately, since it changed them from 3.9.7.0 to s-3.9.7.0.
DocBook-XML doesn't allow section IDs that start with a number, I think?

--
Russ Allbery ([hidden email])               <http://www.eyrie.org/~eagle/>

Reply | Threaded
Open this post in threaded view
|

Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Charles Plessy-12
Le Sun, Apr 30, 2017 at 06:35:29PM -0700, Russ Allbery a écrit :

> Charles Plessy <[hidden email]> writes:
>
> >> -  <section id="s-3.9.8.0">
> >> -    <title>Version 3.9.8.0</title>
> >> +  <section id="s-3.9.8">
> >> +    <title>Version 3.9.8</title>
> >>  
> >>      <para>
> >>        Released April, 2016.
> >> @@ -318,8 +329,8 @@
> >>      </variablelist>
> >>    </section>
> >>  
> >> -  <section id="s-3.9.7.0">
> >> -    <title>Version 3.9.7.0</title>
> >> +  <section id="s-3.9.7">
> >> +    <title>Version 3.9.7</title>
>
> > Hello everybody,
>
> > isn't there a risk to break links with that change ?
>
> The DocBook conversion already broke any links to upgrading-checklist
> sections, unfortunately, since it changed them from 3.9.7.0 to s-3.9.7.0.
> DocBook-XML doesn't allow section IDs that start with a number, I think?

Ah, indeed, DocBook defines the "id" attribute to be of "ID" type in the
sense of the XML standard (https://www.w3.org/TR/REC-xml/#id), which
does not allow them to start with a number.

Have a nice day,

--
Charles

Reply | Threaded
Open this post in threaded view
|

Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Guillem Jover
In reply to this post by Russ Allbery-2
Hi!

On Sun, 2017-04-30 at 18:35:29 -0700, Russ Allbery wrote:

> Charles Plessy <[hidden email]> writes:
>
> >> -  <section id="s-3.9.8.0">
> >> -    <title>Version 3.9.8.0</title>
> >> +  <section id="s-3.9.8">
> >> +    <title>Version 3.9.8</title>
> >>  
> >>      <para>
> >>        Released April, 2016.
> >> @@ -318,8 +329,8 @@
> >>      </variablelist>
> >>    </section>
> >>  
> >> -  <section id="s-3.9.7.0">
> >> -    <title>Version 3.9.7.0</title>
> >> +  <section id="s-3.9.7">
> >> +    <title>Version 3.9.7</title>
>
> > Hello everybody,
>
> > isn't there a risk to break links with that change ?
>
> The DocBook conversion already broke any links to upgrading-checklist
> sections, unfortunately, since it changed them from 3.9.7.0 to s-3.9.7.0.
> DocBook-XML doesn't allow section IDs that start with a number, I think?

I don't think that it did, I tried very hard to preserve all IDs as
they were. I guess you might have gotten confused perhaps, because the
script mapped IDs in upgrading-checklist from [0-9]* to s-[0-9]*, but
that used to be done implicitly by debiandoc-sgml before.

If you check the source of
<https://www.debian.org/doc/debian-policy/upgrading-checklist.html>
you'll see that. :)

Thanks,
Guillem

Reply | Threaded
Open this post in threaded view
|

Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Guillem Jover
In reply to this post by Charles Plessy-12
Hi!

diff --git a/upgrading-checklist.xml b/upgrading-checklist.xml
index ec17af8..83e7c75 100644
--- a/upgrading-checklist.xml
+++ b/upgrading-checklist.xml
[…]
@@ -1438,11 +1449,11 @@
     </variablelist>
   </section>
 
-  <section id="s-3.8.4.0">
-    <title>Version 3.8.4.0</title>
+  <section id="s-3.8.4">
+    <title>Version 3.8.4</title>
 
     <para>
-      Release Jan 2010.
+      Released Janunary, 2010.

Typo.           ^ :)

Thanks,
Guillem

Reply | Threaded
Open this post in threaded view
|

Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Colin Watson
On Fri, May 05, 2017 at 02:19:32PM +0200, Guillem Jover wrote:

> diff --git a/upgrading-checklist.xml b/upgrading-checklist.xml
> index ec17af8..83e7c75 100644
> --- a/upgrading-checklist.xml
> +++ b/upgrading-checklist.xml
> […]
> @@ -1438,11 +1449,11 @@
>      </variablelist>
>    </section>
>  
> -  <section id="s-3.8.4.0">
> -    <title>Version 3.8.4.0</title>
> +  <section id="s-3.8.4">
> +    <title>Version 3.8.4</title>
>  
>      <para>
> -      Release Jan 2010.
> +      Released Janunary, 2010.
                      ^
>
> Typo.           ^ :)

Your typo fix introduces a different typo. :-)

--
Colin Watson                                       [[hidden email]]

Reply | Threaded
Open this post in threaded view
|

Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Russ Allbery-2
In reply to this post by Guillem Jover
Guillem Jover <[hidden email]> writes:

> I don't think that it did, I tried very hard to preserve all IDs as
> they were. I guess you might have gotten confused perhaps, because the
> script mapped IDs in upgrading-checklist from [0-9]* to s-[0-9]*, but
> that used to be done implicitly by debiandoc-sgml before.

Ah!  Yes, that was the part that was confusing me.

So yeah, this would break links that otherwise wouldn't be broken.  I can
go back and change all of the anchors to use the old version numbers.
I'll do that.

--
Russ Allbery ([hidden email])               <http://www.eyrie.org/~eagle/>

Reply | Threaded
Open this post in threaded view
|

Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Guillem Jover
In reply to this post by Colin Watson
On Fri, 2017-05-05 at 18:58:42 +0100, Colin Watson wrote:

> On Fri, May 05, 2017 at 02:19:32PM +0200, Guillem Jover wrote:
> > diff --git a/upgrading-checklist.xml b/upgrading-checklist.xml
> > index ec17af8..83e7c75 100644
> > --- a/upgrading-checklist.xml
> > +++ b/upgrading-checklist.xml
> > […]
> > @@ -1438,11 +1449,11 @@
> >      </variablelist>
> >    </section>
> >  
> > -  <section id="s-3.8.4.0">
> > -    <title>Version 3.8.4.0</title>
> > +  <section id="s-3.8.4">
> > +    <title>Version 3.8.4</title>
> >  
> >      <para>
> > -      Release Jan 2010.
> > +      Released Janunary, 2010.
>                       ^
> >
> > Typo.           ^ :)
>
> Your typo fix introduces a different typo. :-)

This is not a proposed typo fix in patch form, just a botched quoted
patch, sorry for the sloppy concoction of the mail! :)

This is for commit 3e19499ec1650a4d6b7cb6bca7d02238f9609035 from master.

Thanks,
Guillem

Reply | Threaded
Open this post in threaded view
|

Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Russ Allbery-2
In reply to this post by Russ Allbery-2
Russ Allbery <[hidden email]> writes:
> Guillem Jover <[hidden email]> writes:

>> I don't think that it did, I tried very hard to preserve all IDs as
>> they were. I guess you might have gotten confused perhaps, because the
>> script mapped IDs in upgrading-checklist from [0-9]* to s-[0-9]*, but
>> that used to be done implicitly by debiandoc-sgml before.

> Ah!  Yes, that was the part that was confusing me.

> So yeah, this would break links that otherwise wouldn't be broken.  I
> can go back and change all of the anchors to use the old version
> numbers.  I'll do that.

Now fixed, although I'm planning on omitting the non-normative last part
of the version for the anchors for future releases.

--
Russ Allbery ([hidden email])               <http://www.eyrie.org/~eagle/>

Reply | Threaded
Open this post in threaded view
|

Re: [policy] 02/02: Clean up upgrading-checklist, bump version number

Russ Allbery-2
In reply to this post by Guillem Jover
Guillem Jover <[hidden email]> writes:

> diff --git a/upgrading-checklist.xml b/upgrading-checklist.xml
> index ec17af8..83e7c75 100644
> --- a/upgrading-checklist.xml
> +++ b/upgrading-checklist.xml
> […]
> @@ -1438,11 +1449,11 @@
>      </variablelist>
>    </section>
>  
> -  <section id="s-3.8.4.0">
> -    <title>Version 3.8.4.0</title>
> +  <section id="s-3.8.4">
> +    <title>Version 3.8.4</title>
>  
>      <para>
> -      Release Jan 2010.
> +      Released Janunary, 2010.

> Typo.           ^ :)

Thanks, fixed!

--
Russ Allbery ([hidden email])               <http://www.eyrie.org/~eagle/>