Salsa team, and updating ruby-build

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Salsa team, and updating ruby-build

Piper McCorkle-2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello all!

While trying to use rbenv to install the latest version of Ruby, I
realized the version of ruby-build in Debian doesn't support Ruby
versions newer than 2.4.1. I've updated ruby-build to the latest
version locally and would like to upload this updated version to
Debian. I've requested access to the Salsa group so I can push the new
version there. Additionally, to upload to Debian, I'll need a sponsor.
Would someone in debian-ruby be willing to sponsor this upload once I
get the changes pushed to Salsa?

Thanks,
Piper McCorkle
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEQDtD7115tg4GETGb6KgvLJ+z72sFAl6K2hcACgkQ6KgvLJ+z
72sDkBAAkHEejnKBSIJYfk4PVrMOHjjVcSiE/4A4Ta/tcIPm8BthpZXApv1UPptF
2fcwkMgTTzKAzQG99Do0j9X4Jd8TBNb8KxFR3haGBGthcVcQMdCjR3Fmr6/aMyKW
wo86niY0GJRbm8dJZZ4vfcQPmEXvHKjkyYKfeMMUtGmE6M1vycJhWHouZNsta8+I
9Q8V3vT0IpWhYsdmBpoNe2qkV2loBu7AVzT1/Q39zBQjlyqiAbAfucsCPajT2dkT
XanOYaQXUQwi7aQeHrPZw1aiVsZn7oDV3Zu//bbV5bsyhK63A5RLbRFLn9PGqCWH
a0Zr81LlYmHDV/3xCzFHXP2Aia5yefpcTK7UDHDXfYIhtELidF2OeaNAOzfLnnfU
zG/sZ8qJrL7a2ENMEwtdewSdrjXODEVsK4vHciQChOBVVgbUoJksC/n0oh0qJXpl
VlD7mrcJwWccU6jrRU9VwY+rKVBLWucFOYxu7t2UfxgPMbeUI/UZxRvh7gDizWMA
rMtXVjNfJ945PrbyImxfRMmWTOP2vWFlX8EyxHJp2Q6tQAL+ZHtptosLlhC3Cjbz
zbrQ6OwKpdWNf0kJiEKkrXCU1FzQwIepLXSFtsZ9FrIf0xf+HL4xGNkXkk9G8L4x
ey2+bWYIHVR7JjNVTv5EHsZw0f81/tZuPRO5W5COyUacxymoB8g=
=O203
-----END PGP SIGNATURE-----

Reply | Threaded
Open this post in threaded view
|

Re: Salsa team, and updating ruby-build

Piper McCorkle-2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 4/6/20 12:28 AM, Piper McCorkle wrote:
| once I get the changes pushed to Salsa

I've made a fork for the time being, in case someone would like to
take a look: https://salsa.debian.org/pmc-guest/ruby-build
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQDtD7115tg4GETGb6KgvLJ+z72sFAl6K8EAACgkQ6KgvLJ+z
72u8mw//fcOa2BHZLYaCcKEO8XT6jBM1+S53MumpkrRtUKob9ztLG3cyHzs90JrO
1PJpR8ER/+aWZ6QngdnZhrBnHJ2kt6vN4j2QhLUmXhGpgtRV+HdLJlSLftWBmS2m
BxW2ezf+Pdj8F/3/qprCaUx6l7GPwwkMHpYfu92nYpkEXH9P6bYtJAyXEeP412gR
LErMO9//szvJsOZEH42q1RqnZ/QZDqBfY0GChYTDEtAepmDraUXpIAGEGZQi5n1+
bND3bT4ZL75RcPILyl1Oj26elcm1p3XvSid1bojauqsMaLOAKb89FKwo0dAx+z5a
C6h+l26rHpcDkG1/DkQrl7uogJJre3ZFQG5JCpaY34jILjGctZT9sz3OpONU4nFS
D+ShvBz69gfmrO3FHihhfVJT9Z1ynHeRslCaLu23qnPk8sDcXBTaBn5HJy+ylwY+
nZOtz4Jf8+OQ9kqQ8J+FMYZIrMxYgeqjoV023fziGAmvGPWY0DDCdrWqZU/Yfa3/
ZIdmwf1hBrGLNLJrEWgXCwsUYq9gowDMxsKScjhe1q9gOQJdrBAzuw1FwX2KETsq
1Pd+M123Pvs46neYYhPEiT39Mr17XAh71+/SnTuc2dqwiRiREq34oM0igSlCsuqk
2tceQaeycVrBZMbNn0eRnw/WX6zDfVsjcQyIBSiNzskMDVBMCtc=
=fFSj
-----END PGP SIGNATURE-----

Reply | Threaded
Open this post in threaded view
|

Re: Salsa team, and updating ruby-build

Daniel Leidert-2
Am Montag, den 06.04.2020, 02:02 -0700 schrieb Piper McCorkle:
> On 4/6/20 12:28 AM, Piper McCorkle wrote:
> > once I get the changes pushed to Salsa

I've accepted you.

Please wait for one of the maintainers to give you an ok to push a new upstream
version to ruby-team!

> I've made a fork for the time being, in case someone would like to
> take a look: https://salsa.debian.org/pmc-guest/ruby-build

From a very quick look:

You might want to update the Homepage filed in d/control and the Source field
in d/copyright and probably everything d/upstream/metadata (note, that Name and
Contact are obsolete here; the information from Contact goes into d/copyright
as Upstream-Contact).

The build-depends contain a debhelper entry which is obsolete if you use
debhelper-compat.

There are several lintian issues to address:
https://salsa.debian.org/pmc-guest/ruby-build/-/jobs/650340

And I wonder if it belongs into section devel, not ruby.

You might want to address these issues until you get an ok to push to ruby-
team.

Regards, Daniel

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Salsa team, and updating ruby-build

Antonio Terceiro-3
Hello Piper,

Thanks for your contribution.

On Mon, Apr 06, 2020 at 03:38:24PM +0200, Daniel Leidert wrote:

> Am Montag, den 06.04.2020, 02:02 -0700 schrieb Piper McCorkle:
> > On 4/6/20 12:28 AM, Piper McCorkle wrote:
> > > once I get the changes pushed to Salsa
>
> I've accepted you.
>
> Please wait for one of the maintainers to give you an ok to push a new upstream
> version to ruby-team!
>
> > I've made a fork for the time being, in case someone would like to
> > take a look: https://salsa.debian.org/pmc-guest/ruby-build
>
> From a very quick look:
>
> You might want to update the Homepage filed in d/control and the Source field
> in d/copyright and probably everything d/upstream/metadata (note, that Name and
> Contact are obsolete here; the information from Contact goes into d/copyright
> as Upstream-Contact).
>
> The build-depends contain a debhelper entry which is obsolete if you use
> debhelper-compat.
>
> There are several lintian issues to address:
> https://salsa.debian.org/pmc-guest/ruby-build/-/jobs/650340
>
> And I wonder if it belongs into section devel, not ruby.
- the upstream branch should be merged into master. you imported the
  very same content by hand, but it should be a merge instead. you can
  now just merge at the current point, but next time please remember to
  merge from upstream to master instead of replicating the same commit.

- we use pristine-tar to store original tarballs, so please enable it
  your side, and import the tarball: with `pristine-tar commit`

Otherwise it looks good to me modulo the points that Daniel already
raised.

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Salsa team, and updating ruby-build

Piper McCorkle-2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 4/6/20 7:27 AM, Antonio Terceiro wrote:
| Otherwise it looks good to me modulo the points that Daniel
| already raised.

I believe I've resolved those issues, and have pushed the changes to
my fork [1]. I'm CCing Sebastian for review as they uploaded this
package in the past. Thank you all so much for the feedback!

[1]: https://salsa.debian.org/pmc-guest/ruby-build

Thanks,
Piper McCorkle
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQDtD7115tg4GETGb6KgvLJ+z72sFAl6MLw4ACgkQ6KgvLJ+z
72vVBRAAmyPwRS50keeX6wLBkKFZce4UQX47XrODMX0n1CVtaNwPdhmPi45F9813
J3WDXUzgd0FxGgdQI9t5O6S8NphGIKfd39x8ZO3fZ1m80A9WF7EsBLcAG2ebKOJQ
/RiDSfZcu5pwUgTspDIHtrozCeJ1Xb7TWEKMQL8OKzz9wn2vqDhmytqA3ubD+N9d
yAUzVClCdCjZgvjBtxvXFd/DhGUUP6wpNLrnpgSNPkjWMNDXSkh6ECEmDB9R/5uq
PXZx67B4xjxiIacLeeKWTW0t3dMS92BMwA/qBP9w1+nUYMf1noY9GnXZ6XFE2/3z
oTCrzcwzi6N5Zwd/7ZupEZmMAC08JTL927opl80ijT4kAKgzXjx2wEfuqyCHXGpe
AUmtla+fOlNe9k7TmRLMkSJ2ccUgTXDdfc0Zi+/3UAHphhzdScGmcr9Byit6F36E
alDNVhuxijbBGL8cPvrxOIyiHRlE3urxDuM7P3rXnaK3Rpkkj4xCZAB1S41ycfXS
/I4JMb8tUBg+qIr4Lyajiy8od2qpJuppDVVwRNu+Isf8FFEhdINRhMslNKW2K7Ev
fKqDIS28tOx3XrPmIDsjFHnULjlFoZtfkwQUzMU19F84wE1p1HOg5PM9kRrXeiG8
JQqD6lb8oYCPVynJ/UoPypx4ZwGo6BDqBSj9FJ9ick+39NZnuvc=
=rKy4
-----END PGP SIGNATURE-----

Reply | Threaded
Open this post in threaded view
|

Re: Salsa team, and updating ruby-build

Daniel Leidert-2
Am Dienstag, den 07.04.2020, 00:43 -0700 schrieb Piper McCorkle:
> On 4/6/20 7:27 AM, Antonio Terceiro wrote:
> > Otherwise it looks good to me modulo the points that Daniel
> > already raised.
>
> I believe I've resolved those issues, and have pushed the changes to
> my fork [1]. I'm CCing Sebastian for review as they uploaded this
> package in the past. Thank you all so much for the feedback!
>
> [1]: https://salsa.debian.org/pmc-guest/ruby-build

I see a few remaining issues.

- d/copyright needs an update for upstream (check out the copyright notice in
LICENSE).
- I guess you should add yourself to the copyright for debian/* too.
- debian/.gitattributes is still missing. dh-make-ruby will create it for you
(remove the created file debian/ruby-tests.rake).

I'm not sure how I feel about the tests in test/. They require the bats
package. It seems some of these tests are not useful for us and at least two
are failing here. I'd guess that these tests could (or should?) be enabled in
autopkgtest only (using debian/tests/control) and carefully checked if they are
necessary.

If you need assistance please don't hesitate to contact this list or join the
#ruby-team IRC channel.

BTW: We usually build in clean chroots, either using sbuild or pbuilder.
Therefor there shouldn't be a need to add debian/.gitignore. Also if you need
it, add it to debian/.gitattributes.

You can setup a build environment using this script:
https://salsa.debian.org/ruby-team/meta/-/blob/master/setup

... and build using this script:
https://salsa.debian.org/ruby-team/meta/-/blob/master/build

Keep up the good work!

Regards, Daniel

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Salsa team, and updating ruby-build

Daniel Leidert-2
Am Dienstag, den 07.04.2020, 14:15 +0200 schrieb Daniel Leidert:

> Am Dienstag, den 07.04.2020, 00:43 -0700 schrieb Piper McCorkle:
> > On 4/6/20 7:27 AM, Antonio Terceiro wrote:
> > > Otherwise it looks good to me modulo the points that Daniel
> > > already raised.
> >
> > I believe I've resolved those issues, and have pushed the changes to
> > my fork [1]. I'm CCing Sebastian for review as they uploaded this
> > package in the past. Thank you all so much for the feedback!
> >
> > [1]: https://salsa.debian.org/pmc-guest/ruby-build
>
> I see a few remaining issues.
And one more:
ruby-build: manpage-without-executable usr/share/man/man1/rbenv-install.1.gz
ruby-build: manpage-without-executable usr/share/man/man1/rbenv-uninstall.1.g
ruby-build: executable-in-usr-lib usr/lib/rbenv/libexec/rbenv-install
ruby-build: executable-in-usr-lib usr/lib/rbenv/libexec/rbenv-uninstall

Are they supposed to be in /usr/bin?

Regards, Daniel

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Salsa team, and updating ruby-build

Piper McCorkle-2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 4/7/20 5:19 AM, Daniel Leidert wrote:
| And one more: ruby-build: manpage-without-executable
| usr/share/man/man1/rbenv-install.1.gz ruby-build:
| manpage-without-executable usr/share/man/man1/rbenv-uninstall.1.g
| ruby-build: executable-in-usr-lib
| usr/lib/rbenv/libexec/rbenv-install ruby-build:
| executable-in-usr-lib usr/lib/rbenv/libexec/rbenv-uninstall


These are rbenv subcommands, and as far as I can tell belong in
usr/lib/rbenv like the other rbenv subcommands. I'm not sure if
there's a better way to handle the man pages though.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQDtD7115tg4GETGb6KgvLJ+z72sFAl6NQeUACgkQ6KgvLJ+z
72snOg//cSknwcpsX4k5ldOrL3oGgeTQxjpwKaVtZmj+lBcvwq/FfJPtMqNo9FOn
8MUT8m81QujpokseXlPz5eXEt2PcJ7SGNDe9u7lakUEOqGxIJ/gWCY1f0v4Ry9Eb
xDIXhSp/DUroDM3UwTeST69cIn1ZDsKUSR/xhOSsXbJdG0GF1/Bpf54EhynUSq2V
I6I7zc1q6YfOmz6QkcxW9e7gikcidfl3DP1nYvU/BWDnnmfbuLcq8D8jRpNuKFmV
xvr0eHRwab3b+XI4kzF0QR9Ta1peEhkySyQlNTs8XG32nRIPplGH/ziICcSjcuzs
DVbvBPLnuZVZj47/yatFFOrFgKCBJuYMuKirHsz3d5aMX51hWJxJtuCNdr9Q5p8Z
CDQl2qG/TOy/5gxW9LFDHew5vXITWYhG9cYcAjZZuZwcS9YKdgcugO99E/tLs4pE
XTHj+6SdWdFnmCbDI8Yxmn1Slw4eDLo3AZCEZ2RYAhim2UAUenHwLooITp5Ib/uF
wh+sXgGzNYLJsk1LstYaO/u/nca6w8YAWRyxH0txfADFaVC7Q2gd3jCWbtVOZZIF
a9mgW3jZsAgYPd8BwxCLd8m/VUYwoEQA1KqXCOL7olKkdNTNfSsahNUVta8R7tO7
SVTQSE27tFoOsZHlBkG6NTC6tj+dNQ7/qg8aYXAqElsVfdUmHzk=
=HvuD
-----END PGP SIGNATURE-----

Reply | Threaded
Open this post in threaded view
|

Re: Salsa team, and updating ruby-build

Piper McCorkle-2
In reply to this post by Daniel Leidert-2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 4/7/20 5:15 AM, Daniel Leidert wrote:
| I see a few remaining issues.
|
| - d/copyright needs an update for upstream (check out the copyright
| notice in LICENSE). - I guess you should add yourself to the
| copyright for debian/* too.

Updated

| - debian/.gitattributes is still missing. dh-make-ruby will create
| it for you (remove the created file debian/ruby-tests.rake).

Added

| I'm not sure how I feel about the tests in test/. They require the
| bats package. It seems some of these tests are not useful for us
| and at least two are failing here. I'd guess that these tests could
| (or should?) be enabled in autopkgtest only (using
| debian/tests/control) and carefully checked if they are necessary.

I'm not sure where you're going with this: those tests are in the
upstream tarball and I'm only running them in autopkgtest.

| If you need assistance please don't hesitate to contact this list
| or join the #ruby-team IRC channel. ...> Keep up the good work!

Thank you for the help!
Piper McCorkle
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQDtD7115tg4GETGb6KgvLJ+z72sFAl6NQlgACgkQ6KgvLJ+z
72vODhAAgwLTwZVnAcQ1fMz7uXS/S54SwNviP1psf+s8WIrJg9q8qmluLRMs3A0i
IPkxWNZuF09yFe5uvIFSwHTmJsD3tPSDOkPWOPWFEb1mncXZuBt5gyCEm6MRqWnK
tCkyQSQnDIqHg1coDXwMTOXNhypDhr0mHs+As36i88g1B9RIeQhiRdwzg2OeBnZv
8yeF1C7LY1qSiTC8Bzn6augBoDPzqiupd9N/Ks4wcUF1dfsp6x0CyPaHaJcybFhm
KFiijDCOFAp5PWs2hn9WV9UGn2U6W02Y8oiefi2/kzH6JqK0wQggm2RoHUoHceFa
iI29bvmZVoej7GIGmMkEXRMezwe5esOd00xIbONL/BmLSFimo85hmiGEJEysxvTU
sVSiLYbGVWbucTgzqE7bREBHhO864i2MInIC2GiwvjW6vtuotaTgVE5lPdPIU6JL
diytGvY9ZTV13hqglfo8JA0v2X3thu7UP08ob5lPPDBZ1rvc5uI8/tcT5Pc6lESR
ZAnKpOw+oa1iFt1AtxwK74qh1bYCciRNkKmt/t8AQel+oQTAHHTkyjk0aACn5Rb5
qjCfNvmJlQkhRRTHvcD1hdmZ8Fgdy/R67ZBtywjpv+ucyYK6fWQvSp7iHB/ltZFB
nYM2PbaEalcajve8brEKRd0sR9AsKwGYffsk6J8yQqN+Cc3APv8=
=oUrZ
-----END PGP SIGNATURE-----

Reply | Threaded
Open this post in threaded view
|

Re: Salsa team, and updating ruby-build

Daniel Leidert-2
Am Dienstag, den 07.04.2020, 20:17 -0700 schrieb Piper McCorkle:

> On 4/7/20 5:15 AM, Daniel Leidert wrote:
> > I see a few remaining issues.
> >
> > - d/copyright needs an update for upstream (check out the copyright
> > notice in LICENSE). - I guess you should add yourself to the
> > copyright for debian/* too.
>
> Updated
>
> > - debian/.gitattributes is still missing. dh-make-ruby will create
> > it for you (remove the created file debian/ruby-tests.rake).
>
> Added
>
> > I'm not sure how I feel about the tests in test/. They require the
> > bats package. It seems some of these tests are not useful for us
> > and at least two are failing here. I'd guess that these tests could
> > (or should?) be enabled in autopkgtest only (using
> > debian/tests/control) and carefully checked if they are necessary.
>
> I'm not sure where you're going with this: those tests are in the
> upstream tarball and I'm only running them in autopkgtest.
My mistake. I missed that.

I pushed your changes to ruby-team/ruby-build, finalized your changelog and
uploaded the package.

https://salsa.debian.org/ruby-team/ruby-build

Well done.

Regards, Daniel

signature.asc (849 bytes) Download Attachment