[debian-installer] Korean installation-guide PDF

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[debian-installer] Korean installation-guide PDF

Holger Wansing-4
Hi Changwoo,

recently you have committed changings to use different fonts for Korean PDF
variant of Debian's installation-guide.

Now, Korean PDF fails to build.

Did it work for you, when you tested that?
Maybe there are more build dependencies to be added?

Could you have a look?


Thanks
Holger


--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Samuel Thibault-8
Hello,

Holger Wansing, le ven. 14 juin 2019 15:09:22 +0200, a ecrit:
> recently you have committed changings to use different fonts for Korean PDF
> variant of Debian's installation-guide.
>
> Now, Korean PDF fails to build.

Oh?

> Did it work for you, when you tested that?

I did test before committing the changes under his name, yes, and the
package builds fine with pbuilder from a bare chroot.

> Maybe there are more build dependencies to be added?

Some were added indeed, and I made a jenkins pull request to add them:

commit 9ec32490f1a4c61b006f02e4a832b048c84a7b04 (HEAD -> master, mine/master)
Author: Samuel Thibault <[hidden email]>
Date:   Sun Jun 2 11:30:35 2019 +0200

d-i_manual: Update korean dependencies

diff --git a/job-cfg/schroot.yaml b/job-cfg/schroot.yaml
index 6501f43f..60a05bcf 100644
--- a/job-cfg/schroot.yaml
+++ b/job-cfg/schroot.yaml
@@ -76,7 +76,7 @@
                - 'd-i_{name}-sid-create':
                        my_schroot: d-i-sid
                        my_distro: sid
                        my_extra_pkgs: 'build-essential debhelper docbook docbook-xml docbook-xsl xsltproc gawk libhtml-parser-perl w3m poxml jadetex openjade dblatex docbook-dsssl ghostscript texlive-xetex lmodern texlive-lang-cyrillic texlive-lang-czechslovak texlive-lang-european texlive-lang-french texlive-lang-german texlive-lang-greek texlive-lang-italian {+texlive-lang-korean,+} texlive-lang-other texlive-lang-portuguese texlive-lang-spanish ko.tex-base cm-super fonts-wqy-microhei fonts-vlgothic {+fonts-noto-cjk+} fonts-freefont-ttf'
                        my_time: '1 1 * * 1'    # create it weekly
                - 'd-i_{name}-sid-upgrade':
                        my_schroot: d-i-sid


Samuel

Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Holger Wansing-4

Hi,

Am Freitag, 14. Juni 2019 schrieb Samuel Thibault:

> Hello,
>
> Holger Wansing, le ven. 14 juin 2019 15:09:22 +0200, a ecrit:
> > recently you have committed changings to use different fonts for Korean PDF
> > variant of Debian's installation-guide.
> >
> > Now, Korean PDF fails to build.
>
> Oh?
>
> > Did it work for you, when you tested that?
>
> I did test before committing the changes under his name, yes, and the
> package builds fine with pbuilder from a bare chroot.

Hmm, the build of the PDFs fail on dillon, and so it does on
my laptop here.
I however only did
"./buildone_ng.sh amd64 ko pdf"
from the build dir.

Holger


--
Sent from my Jolla phone
http://www.jolla.com/
Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Samuel Thibault-8
Holger Wansing, le ven. 14 juin 2019 15:42:33 +0000, a ecrit:
> I however only did
> "./buildone_ng.sh amd64 ko pdf"
> from the build dir.

Did you check

  dpkg-checkbuilddeps

?

Samuel

Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Holger Wansing-4
Hi,

Samuel Thibault <[hidden email]> wrote:
> Holger Wansing, le ven. 14 juin 2019 15:42:33 +0000, a ecrit:
> > I however only did
> > "./buildone_ng.sh amd64 ko pdf"
> > from the build dir.
>
> Did you check
>
>   dpkg-checkbuilddeps

Yes, everything fine there.


Holger


--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Holger Wansing-4
Hi,

Holger Wansing <[hidden email]> wrote:

> Hi,
>
> Samuel Thibault <[hidden email]> wrote:
> > Holger Wansing, le ven. 14 juin 2019 15:42:33 +0000, a ecrit:
> > > I however only did
> > > "./buildone_ng.sh amd64 ko pdf"
> > > from the build dir.
> >
> > Did you check
> >
> >   dpkg-checkbuilddeps
>
> Yes, everything fine there.

However, dillon is reporting that
texlive-lang-korean and fonts-noto-cjk
are missing.

Do we need to get DSA install them there?


Holger



--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Holger Wansing-4
In reply to this post by Holger Wansing-4
Hi,

Am Freitag, 14. Juni 2019 schrieb Holger Wansing:

>
> Hi,
>
> Am Freitag, 14. Juni 2019 schrieb Samuel Thibault:
> > Hello,
> >
> > Holger Wansing, le ven. 14 juin 2019 15:09:22 +0200, a ecrit:
> > > recently you have committed changings to use different fonts for Korean PDF
> > > variant of Debian's installation-guide.
> > >
> > > Now, Korean PDF fails to build.
> >
> > Oh?
> >
> > > Did it work for you, when you tested that?
> >
> > I did test before committing the changes under his name, yes, and the
> > package builds fine with pbuilder from a bare chroot.
>
> Hmm, the build of the PDFs fail on dillon, and so it does on
> my laptop here.
> I however only did
> "./buildone_ng.sh amd64 ko pdf"
> from the build dir.

While the fail was on stable, I confirm that it works fine on
an unstable machine.
So it seems, the used font is not available in the stretch version
of the package.
Is this a problem?
At least, the PDFs cannot be built on dillon now for the preview
website.


Holger

--
Sent from my Jolla phone
http://www.jolla.com/
Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Samuel Thibault-8
Holger Wansing, le dim. 16 juin 2019 05:37:49 +0000, a ecrit:
> So it seems, the used font is not available in the stretch version
> of the package.

Ah.

> Is this a problem?

I don't think it is, exectp for

> At least, the PDFs cannot be built on dillon now for the preview
> website.

We'll want to upgrade dillon sooner or later anyway?

Samuel

Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Holger Wansing-4
Hi,

Samuel Thibault <[hidden email]> wrote:

> Holger Wansing, le dim. 16 juin 2019 05:37:49 +0000, a ecrit:
> > So it seems, the used font is not available in the stretch version
> > of the package.
>
> Ah.
>
> > Is this a problem?
>
> I don't think it is, exectp for
>
> > At least, the PDFs cannot be built on dillon now for the preview
> > website.
>
> We'll want to upgrade dillon sooner or later anyway?

Yes, sure. DSA will do.

I remembered another point: the build of installation-guide for the website,
when Buster is out, at https://www.debian.org/releases/stable/installmanual

That will be the same problem: the machine is then still Stretch.
And the build will fail then.

(Of course, it's not optimal, that for the website build the manual is build
from scratch; they should better unpack the content of the installation-guide
package and it would be done. That has already been proposed, but noone has
changed it like that until now.)

That's buildweb.sh in the build dir, and when I tested it here locally, the
script stops immediately at the first Korean PDF, so many languages will not
be built at all.



Holger


--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Samuel Thibault-8
Hello,

Changwoo, do you think you can come up with some simple change to let it
build on Stretch?  We can probably make it conditional, so that it's only
the immediate builds which will be using the fonts from Stretch, and
further builds will use the fonts you picked up from Buster.

Samuel

Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Holger Wansing-4
Hi,

Samuel Thibault <[hidden email]> wrote:
> Hello,
>
> Changwoo, do you think you can come up with some simple change to let it
> build on Stretch?  We can probably make it conditional, so that it's only
> the immediate builds which will be using the fonts from Stretch, and
> further builds will use the fonts you picked up from Buster.

It's just a matter of reverting the latest "Improve Korean pdf" changings
and thus using WenQuanYi Micro Hei font again until Buster is out.

Then, we can switch to the use of Noto * CJK KR font.

Any objections against this solution path?


Holger


--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Samuel Thibault-8
Hello,

Holger Wansing, le mar. 18 juin 2019 23:55:29 +0200, a ecrit:

> Samuel Thibault <[hidden email]> wrote:
> > Hello,
> >
> > Changwoo, do you think you can come up with some simple change to let it
> > build on Stretch?  We can probably make it conditional, so that it's only
> > the immediate builds which will be using the fonts from Stretch, and
> > further builds will use the fonts you picked up from Buster.
>
> It's just a matter of reverting the latest "Improve Korean pdf" changings
> and thus using WenQuanYi Micro Hei font again until Buster is out.
>
> Then, we can switch to the use of Noto * CJK KR font.
>
> Any objections against this solution path?

I have now reverted the font part of the commit.

Samuel

Reply | Threaded
Open this post in threaded view
|

Some more build dependencies for installation-guide to be installed on dillon

Holger Wansing-4
Hi,

recently there were some changes on the installation-guide for Korean,
which lead to additional build dependencies for that package.


Could you please install

texlive-lang-korean
fonts-nanum
fonts-nanum-coding

on dillon please?


The preview version of the installation-guide (see
https://d-i.debian.org/manual/) is built on dillon.


Thanks
Holger


--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

Reply | Threaded
Open this post in threaded view
|

Re: Some more build dependencies for installation-guide to be installed on dillon

Cyril Brulebois-4
Hi Holger,

Holger Wansing <[hidden email]> (2019-06-22):

> recently there were some changes on the installation-guide for Korean,
> which lead to additional build dependencies for that package.
>
>
> Could you please install
>
> texlive-lang-korean
> fonts-nanum
> fonts-nanum-coding
>
> on dillon please?
>
>
> The preview version of the installation-guide (see
> https://d-i.debian.org/manual/) is built on dillon.
Unless that has changed over the last few months, one would usually propose a
patch against DSA's debian.org source metapackage:
  https://salsa.debian.org/dsa-team/mirror/debian.org/blob/master/debian/control#L1041

See the “Package: debian.org-d-i.debian.org” stanza.

After the patch has been merged, they can deploy updated binary
(or binaries) on the target machine(s).


Cheers,
--
Cyril Brulebois ([hidden email])            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Some more build dependencies for installation-guide to be installed on dillon

Holger Wansing-4
Hi,

Cyril Brulebois <[hidden email]> wrote:

> Hi Holger,
>
> Holger Wansing <[hidden email]> (2019-06-22):
> > recently there were some changes on the installation-guide for Korean,
> > which lead to additional build dependencies for that package.
> >
> >
> > Could you please install
> >
> > texlive-lang-korean
> > fonts-nanum
> > fonts-nanum-coding
> >
> > on dillon please?
> >
> >
> > The preview version of the installation-guide (see
> > https://d-i.debian.org/manual/) is built on dillon.
>
> Unless that has changed over the last few months, one would usually propose a
> patch against DSA's debian.org source metapackage:
>   https://salsa.debian.org/dsa-team/mirror/debian.org/blob/master/debian/control#L1041
>
> See the “Package: debian.org-d-i.debian.org” stanza.
>
> After the patch has been merged, they can deploy updated binary
> (or binaries) on the target machine(s).
Cyril,

many thanks for your answer.



@DSA: The mentioned patch is attached.

Holger


--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

debian_control.diff (527 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Some more build dependencies for installation-guide to be installed on dillon

Holger Wansing-4
Hi,

Holger Wansing <[hidden email]> wrote:

> Hi,
>
> Cyril Brulebois <[hidden email]> wrote:
> > Hi Holger,
> >
> > Holger Wansing <[hidden email]> (2019-06-22):
> > > recently there were some changes on the installation-guide for Korean,
> > > which lead to additional build dependencies for that package.
> > >
> > >
> > > Could you please install
> > >
> > > texlive-lang-korean
> > > fonts-nanum
> > > fonts-nanum-coding
> > >
> > > on dillon please?
> > >
> > >
> > > The preview version of the installation-guide (see
> > > https://d-i.debian.org/manual/) is built on dillon.
> >
> > Unless that has changed over the last few months, one would usually propose a
> > patch against DSA's debian.org source metapackage:
> >   https://salsa.debian.org/dsa-team/mirror/debian.org/blob/master/debian/control#L1041
> >
> > See the “Package: debian.org-d-i.debian.org” stanza.
> >
> > After the patch has been merged, they can deploy updated binary
> > (or binaries) on the target machine(s).
A 'git format-patch' created patch is attached.

Holger


--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

0001-Add-some-additional-build-dependencies-for-Korean-PD.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Some more build dependencies for installation-guide to be installed on dillon

Peter Palfrader
On Tue, 25 Jun 2019, Holger Wansing wrote:

> A 'git format-patch' created patch is attached.

merged, pushed, built, installed, upgraded.

Thanks!
--
                            |  .''`.       ** Debian **
      Peter Palfrader       | : :' :      The  universal
 https://www.palfrader.org/ | `. `'      Operating System
                            |   `-    https://www.debian.org/

Reply | Threaded
Open this post in threaded view
|

Re: Some more build dependencies for installation-guide to be installed on dillon

Holger Wansing-4
Hi,

Peter Palfrader <[hidden email]> wrote:
> On Tue, 25 Jun 2019, Holger Wansing wrote:
>
> > A 'git format-patch' created patch is attached.
>
> merged, pushed, built, installed, upgraded.

Yes, Korean PDF now build fine again on dillon!

Thanks!


Holger


--
Holger Wansing <[hidden email]>
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

Reply | Threaded
Open this post in threaded view
|

Re: [debian-installer] Korean installation-guide PDF

Changwoo Ryu
In reply to this post by Samuel Thibault-8
Hello,

Sorry for the delays.

2019년 6월 21일 (금) 오전 5:48, Samuel Thibault <[hidden email]>님이 작성:>

> Hello,
>
> Holger Wansing, le mar. 18 juin 2019 23:55:29 +0200, a ecrit:
> > Samuel Thibault <[hidden email]> wrote:
> > > Hello,
> > >
> > > Changwoo, do you think you can come up with some simple change to let it
> > > build on Stretch?  We can probably make it conditional, so that it's only
> > > the immediate builds which will be using the fonts from Stretch, and
> > > further builds will use the fonts you picked up from Buster.

OK so I found the problem was that fonts-noto-cjk on stretch had only
Noto Sans and Noto Sans Mono, not Noto Serif.

> > It's just a matter of reverting the latest "Improve Korean pdf" changings
> > and thus using WenQuanYi Micro Hei font again until Buster is out.
> >
> > Then, we can switch to the use of Noto * CJK KR font.
> >
> > Any objections against this solution path?
>
> I have now reverted the font part of the commit.

I agree this revert which switch back to nanum fonts. The additional
packages (texlive-lang-korean, fonts-nanum and fonts-nanum-coding)
still need to be installed on build machines.

--
Changwoo