lxqt-config: FTBFS on hurd-i386: udev not available

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

lxqt-config: FTBFS on hurd-i386: udev not available

Paul Sonnenschein
Package: lxqt-config
Severity: important
Version: 0.14.1-2
Tags: patch
User: [hidden email]
Usertags: hurd

(Sending to debian-bsd because the patch also affects kfreebsd)

Dear maintainer,

the package lxqt-config fails to build from source on hurd-i386 because
udev is not available on non-linux (on kfreebsd-any, it is in state BD-
Uninstallable).

If the option WITH_TOUCHPAD is disabled, lxqt-config compiles.

The applied patch disables WITH_TOUCHPAD on non-linux architectures and
is based on [0].

I have not tested on kfreebsd, the patch should however be necessary
for kfreebsd too.

Thanks.

Build-Log:
https://buildd.debian.org/status/fetch.php?pkg=lxqt-config&arch=hurd-i386&ver=0.14.1-2&stamp=1564267325&raw=0
[0]:
https://salsa.debian.org/lxqt-team/lxqt-panel/blob/debian/sid/debian/rules

lxqt-config-no-touchpad.patch (972 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: lxqt-config: FTBFS on hurd-i386: udev not available

Guillem Jover
Hi!

On Mon, 2019-07-29 at 13:49:45 +0200, Paul Sonnenschein wrote:

> Package: lxqt-config
> Severity: important
> Version: 0.14.1-2
> Tags: patch
> User: [hidden email]
> Usertags: hurd
>
> the package lxqt-config fails to build from source on hurd-i386 because
> udev is not available on non-linux (on kfreebsd-any, it is in state BD-
> Uninstallable).

> diff --git a/debian/rules b/debian/rules
> index 4f7c70d..81335e7 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -5,6 +5,12 @@ export LC_ALL=C.UTF-8
>  export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
>  export DEB_BUILD_MAINT_OPTIONS = hardening=+all
>  
> +WHICH_OS := $(shell dpkg-architecture -qDEB_HOST_ARCH_OS 2>/dev/null)

The usual convention is to use the same name as the queried variable,
so «DEB_HOST_ARCH_OS = ...», but I think even better would be to just
do «include /usr/share/dpkg/architecture.mk» and then just use the
needed variables lazily defined there.

> +ifneq  ($(WHICH_OS), linux)
> +    NOT_LINUX := -DWITH_TOUCHPAD=NO
> +endif

To make this variable reusable, I'd probably give it a system agnostic
name, I tend to use something like:

  confflags += -DWITH_TOUCHPAD=NO

so that it can be extended, w/o rendering the name invalid.

Thanks,
Guillem

Reply | Threaded
Open this post in threaded view
|

Re: lxqt-config: FTBFS on hurd-i386: udev not available

Paul Sonnenschein
Hi!

Am Montag, den 29.07.2019, 18:37 +0200 schrieb Guillem Jover:

> [...]
>
> The usual convention is to use the same name as the queried variable,
> so «DEB_HOST_ARCH_OS = ...», but I think even better would be to just
> do «include /usr/share/dpkg/architecture.mk» and then just use the
> needed variables lazily defined there.
>
> [...] I tend to use something like:
>
>   confflags += -DWITH_TOUCHPAD=NO
>
> so that it can be extended, w/o rendering the name invalid.
Updated patch according to Guillem's proposals.

> [...]

Thanks

lxqt-config-no-touchpad.patch (1008 bytes) Download Attachment