no dark theme in gnome-terminal 3.16 anymore?

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

no dark theme in gnome-terminal 3.16 anymore?

Bastian Venthur-3
Hi,

with doday's update, gnome-terminal got updated from 3.14 to 3.16. After
restarting the running terminals, I realized that the top window border
changed from dark to light. If I remember correctly, in < 3.16 it was
possible to configure whether gnome-terminal uses the dark theme or not,
but this option has disappeared.

Any chance to bring that option back, or make the dark theme the default?


Cheers,

Bastian




--
Bastian Venthur                                      http://venthur.de
Debian Developer                                 venthur at debian org



--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: https://lists.debian.org/mkh0n8$qmt$1@...

Reply | Threaded
Open this post in threaded view
|

Re: no dark theme in gnome-terminal 3.16 anymore?

Sven Arvidsson
On Mon, 2015-06-01 at 09:13 +0200, Bastian Venthur wrote:
> Hi,
>
> with doday's update, gnome-terminal got updated from 3.14 to 3.16. After
> restarting the running terminals, I realized that the top window border
> changed from dark to light. If I remember correctly, in < 3.16 it was
> possible to configure whether gnome-terminal uses the dark theme or not,
> but this option has disappeared.
>
> Any chance to bring that option back, or make the dark theme the default?

Looks like it was a bunch of problems with that feature:

commit 5f6c514a8840a5d1b87a8c399defee3b5052ec18
Author: Christian Persch <[hidden email]>
Date:   Thu Jan 8 14:08:43 2015 +0100

    prefs: Remove dark theme pref
   
    It's more trouble than it's worth.
   
    https://bugzilla.gnome.org/show_bug.cgi?id=707206
    https://bugzilla.gnome.org/show_bug.cgi?id=742040
    https://bugzilla.gnome.org/show_bug.cgi?id=742333
    https://bugzilla.gnome.org/show_bug.cgi?id=649358

 src/org.gnome.Terminal.gschema.xml |  5 -----
 src/preferences.ui                 | 16 ----------------
 src/terminal-app.c                 |  4 ----
 src/terminal-prefs.c               |  9 +--------
 src/terminal-schemas.h             |  1 -
 5 files changed, 1 insertion(+), 34 deletions(-)

--
Cheers,
Sven Arvidsson
http://www.whiz.se
PGP Key ID 6FAB5CD5



signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: no dark theme in gnome-terminal 3.16 anymore?

Bastian Venthur-3
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Sven,

thanks for the research! Sorry to see that feature go. The light
titlebar looks very distracting, especially if you use a dark terminal
theme and have the terminal in fullscreen. But anyways, thanks you!


Cheers,

Bastian


Am 01.06.2015 um 11:14 schrieb Sven Arvidsson:

> On Mon, 2015-06-01 at 09:13 +0200, Bastian Venthur wrote:
>> Hi,
>>
>> with doday's update, gnome-terminal got updated from 3.14 to
>> 3.16. After restarting the running terminals, I realized that the
>> top window border changed from dark to light. If I remember
>> correctly, in < 3.16 it was possible to configure whether
>> gnome-terminal uses the dark theme or not, but this option has
>> disappeared.
>>
>> Any chance to bring that option back, or make the dark theme the
>> default?
>
> Looks like it was a bunch of problems with that feature:
>
> commit 5f6c514a8840a5d1b87a8c399defee3b5052ec18 Author: Christian
> Persch <[hidden email]> Date:   Thu Jan 8 14:08:43 2015 +0100
>
> prefs: Remove dark theme pref
>
> It's more trouble than it's worth.
>
> https://bugzilla.gnome.org/show_bug.cgi?id=707206 
> https://bugzilla.gnome.org/show_bug.cgi?id=742040 
> https://bugzilla.gnome.org/show_bug.cgi?id=742333 
> https://bugzilla.gnome.org/show_bug.cgi?id=649358
>
> src/org.gnome.Terminal.gschema.xml |  5 ----- src/preferences.ui
> | 16 ---------------- src/terminal-app.c                 |  4 ----
> src/terminal-prefs.c               |  9 +--------
> src/terminal-schemas.h             |  1 - 5 files changed, 1
> insertion(+), 34 deletions(-)
>


- --
Bastian Venthur                                      http://venthur.de
Debian Developer                                 venthur at debian org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVbCuJAAoJEI6IlUTZhQANuDEP/jtyf+KCeBxqtdvKTVtG7+Lt
WBSb3QDtFrbtV90bcAp4rgUX2EH4mEjYoMZWVKHZRRo9mj95mGR2FcxJT8bgcK4L
aqgzsF2c48cbQRp8OZxmFrwgPZAwVcLspADuU4NYKqT0ITZRDa2GjTKx2T/gzhlc
FbYOlKH6aoX0sNdJ+TCXDpV3U2FY4oXhnOtHlHj7zCXsASL9R7REDYO8z5g6/pOo
vRHWWGflpokYo1Kz7nJyVDxSpGxK8GR8Qw8sQFRdBrcGIng7FmkxceKIZNw5rRhY
N21rqzDfRtsWgLkFqN+GrEnJK4YGSM9ATqrfGgBDhp7Qo9Av6OUSEDnA04Gjx4RB
ZUgXKQHFBL98XAzAfDDPuss1/XlLnAbIHQSOQgEyYACC3WHUBgculOWJtQbpXFlN
h/EZZFRgN8mDu88QyM4RfLIfGqRDaGBT0LiZoS7Bn86tG1PW2xS3IgwHpJ95ekuH
HwV3gg7j6J5MHD7wHi4rEYyt8gZooZx+arz3lZt+yCyDMla9ekgxtggSuhqNQt76
f6hqAATjFujaZYDnOle7m5ciOI48i44mOODSbw98S9XEJ8WT32wOqDCTfjSVADm0
BSFufqmZczEZ/5p+lEcnA6kw5Dopswqi6nq3uQGpM+TungVoD/z3rQKGWJ2+EM73
ZyjDDVCnVHYK2fXPb9Fz
=b+WP
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: https://lists.debian.org/mkha29$e0p$1@...

Reply | Threaded
Open this post in threaded view
|

Re: no dark theme in gnome-terminal 3.16 anymore?

Sven Arvidsson
On Mon, 2015-06-01 at 11:53 +0200, Bastian Venthur wrote:
> Hi Sven,
>
> thanks for the research! Sorry to see that feature go. The light
> titlebar looks very distracting, especially if you use a dark terminal
> theme and have the terminal in fullscreen. But anyways, thanks you!

Yes, I'm also sorry to see it go.

Looks like at least Fedora, OpenSUSE and possibly Arch are patching it
back in. Maybe Debian should do the same?

--
Cheers,
Sven Arvidsson
http://www.whiz.se
PGP Key ID 6FAB5CD5



signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: no dark theme in gnome-terminal 3.16 anymore?

Jon Häggblad
On Mon, Jun 01, 2015 at 01:27:38PM +0200, Sven Arvidsson wrote:

> On Mon, 2015-06-01 at 11:53 +0200, Bastian Venthur wrote:
> > Hi Sven,
> >
> > thanks for the research! Sorry to see that feature go. The light
> > titlebar looks very distracting, especially if you use a dark terminal
> > theme and have the terminal in fullscreen. But anyways, thanks you!
>
> Yes, I'm also sorry to see it go.
>
> Looks like at least Fedora, OpenSUSE and possibly Arch are patching it
> back in. Maybe Debian should do the same?

Agree, very sad. A patched version of gnome-terminal would be most
welcome, IMHO.

Cheers,
Jon


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: https://lists.debian.org/20150614135723.GA29324@...

Reply | Threaded
Open this post in threaded view
|

Re: no dark theme in gnome-terminal 3.16 anymore?

Sebastian Lara

2015-06-14 10:57 GMT-03:00 Jon Häggblad <[hidden email]>:
On Mon, Jun 01, 2015 at 01:27:38PM +0200, Sven Arvidsson wrote:
> On Mon, 2015-06-01 at 11:53 +0200, Bastian Venthur wrote:
> > Hi Sven,
> >
> > thanks for the research! Sorry to see that feature go. The light
> > titlebar looks very distracting, especially if you use a dark terminal
> > theme and have the terminal in fullscreen. But anyways, thanks you!

I use the Pixel Saver extension [1] for this. Works fine with Gnome 3.16 in Sid 
 

--
Sebastián Lara Menares
Reply | Threaded
Open this post in threaded view
|

Re: no dark theme in gnome-terminal 3.16 anymore?

Sebastian Lara Menares-2
In reply to this post by Jon Häggblad

2015-06-14 10:57 GMT-03:00 Jon Häggblad <[hidden email]>:
On Mon, Jun 01, 2015 at 01:27:38PM +0200, Sven Arvidsson wrote:
> On Mon, 2015-06-01 at 11:53 +0200, Bastian Venthur wrote:
> > Hi Sven,
> >
> > thanks for the research! Sorry to see that feature go. The light
> > titlebar looks very distracting, especially if you use a dark terminal
> > theme and have the terminal in fullscreen. But anyways, thanks you!

I use the Pixel Saver extension [1] for this. Works fine with Gnome 3.16 in Sid 
 
 
-- 
Sebastián Lara Menares
Reply | Threaded
Open this post in threaded view
|

Re: no dark theme in gnome-terminal 3.16 anymore?

Josh Triplett-9
In reply to this post by Sven Arvidsson
Sven Arvidsson wrote:

> On Mon, 2015-06-01 at 11:53 +0200, Bastian Venthur wrote:
> > Hi Sven,
> >
> > thanks for the research! Sorry to see that feature go. The light
> > titlebar looks very distracting, especially if you use a dark terminal
> > theme and have the terminal in fullscreen. But anyways, thanks you!
>
> Yes, I'm also sorry to see it go.
>
> Looks like at least Fedora, OpenSUSE and possibly Arch are patching it
> back in. Maybe Debian should do the same?

Rather than attempting to patch that option back into gnome-terminal, I
*think* it may be possible to set the dark theme for an application via
gtk.css, matching on properties of the application/window.  And if not,
then perhaps we could get upstream to add such a mechanism.  That would
then allow users to easily switch entire applications to use the dark
theme, with no per-application code.

We could then easily make gnome-terminal use the dark theme by default
via the system gtk.css.

- Josh Triplett


--
To UNSUBSCRIBE, email to [hidden email]
with a subject of "unsubscribe". Trouble? Contact [hidden email]
Archive: https://lists.debian.org/20150709201621.GA26058@jtriplet-mobl1

Reply | Threaded
Open this post in threaded view
|

Re: no dark theme in gnome-terminal 3.16 anymore?

Andrea Vettorello

On Thu, Jul 9, 2015 at 10:16 PM, Josh Triplett <[hidden email]> wrote:
Rather than attempting to patch that option back into gnome-terminal, I
*think* it may be possible to set the dark theme for an application via
gtk.css, matching on properties of the application/window. 

Hi,

I was looking to do the same with Emacs, and if I recall correctly, it's the application that needs to request/support the dark variant of a theme (I'm using the default Adwaita), but I haven't yet verified how it's done, for example, in EOG.

Copying around, I've created an ugly hack with xprop inside Emacs, but it only affects the titlebar, so in the case of a gnome-terminal you still have tabs rendered with Adwaita's light variant...


--
Andrea