ruby-premailer build failure in salsa ci

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

ruby-premailer build failure in salsa ci

Pirate Praveen-3
It fails with error,

Encoding::InvalidByteSequenceError: "\xE2" on US-ASCII


Though it built fine in sbuild. I think salsa ci should use sbuild or same settings as sbuild.
Reply | Threaded
Open this post in threaded view
|

Re: ruby-premailer build failure in salsa ci

Daniel Leidert-2
Am Mittwoch, den 14.08.2019, 22:21 +0500 schrieb Pirate Praveen:
> It fails with error,
>
> Encoding::InvalidByteSequenceError: "\xE2" on US-ASCII
>
> full log https://salsa.debian.org/ruby-team/ruby-premailer/-/jobs/276596
>
> Though it built fine in sbuild. I think salsa ci should use sbuild or same
> settings as sbuild.

Can you try and install locales-all too? This helped me with a similar issue.

HTH and regards, Daniel


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ruby-premailer build failure in salsa ci

Antonio Terceiro-3
In reply to this post by Pirate Praveen-3
On Wed, Aug 14, 2019 at 10:21:51PM +0500, Pirate Praveen wrote:
> It fails with error,
>
> Encoding::InvalidByteSequenceError: "\xE2" on US-ASCII
>
> full log <https://salsa.debian.org/ruby-team/ruby-premailer/-/jobs/276596>
>
> Though it built fine in sbuild. I think salsa ci should use sbuild or same
> settings as sbuild.

It's probably more useful to report issues like this to the salsa-ci
team directly. There is no ML yet but there is #salsaci on OFTC.

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ruby-premailer build failure in salsa ci

Daniel Leidert-2
In reply to this post by Daniel Leidert-2
Am Mittwoch, den 14.08.2019, 21:45 +0200 schrieb Daniel Leidert:

> Am Mittwoch, den 14.08.2019, 22:21 +0500 schrieb Pirate Praveen:
> > It fails with error,
> >
> > Encoding::InvalidByteSequenceError: "\xE2" on US-ASCII
> >
> > full log https://salsa.debian.org/ruby-team/ruby-premailer/-/jobs/276596
> >
> > Though it built fine in sbuild. I think salsa ci should use sbuild or same
> > settings as sbuild.
>
> Can you try and install locales-all too? This helped me with a similar issue.
I now have a similar issue with ruby-jekyll-feed enabling the tests. The tests
succeed, if LC_ALL/LANG are set to C.UTF-8, but they fail with the default,
which is 'C'. You can try to add this to salsa-ci.yml:

variables:
  LC_ALL: C.UTF-8
  LANG: C.UTF-8

It is possible, that you still need to install locales-all or need some
encoding.

Regards, Daniel
>

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ruby-premailer build failure in salsa ci

Utkarsh Gupta
Hey,

On 15/08/19 8:20 am, Daniel Leidert wrote:

> Am Mittwoch, den 14.08.2019, 21:45 +0200 schrieb Daniel Leidert:
>> Am Mittwoch, den 14.08.2019, 22:21 +0500 schrieb Pirate Praveen:
>>> It fails with error,
>>>
>>> Encoding::InvalidByteSequenceError: "\xE2" on US-ASCII
>>>
>>> full log https://salsa.debian.org/ruby-team/ruby-premailer/-/jobs/276596
>>>
>>> Though it built fine in sbuild. I think salsa ci should use sbuild or same
>>> settings as sbuild.
>> Can you try and install locales-all too? This helped me with a similar issue.
> I now have a similar issue with ruby-jekyll-feed enabling the tests. The tests
> succeed, if LC_ALL/LANG are set to C.UTF-8, but they fail with the default,
> which is 'C'. You can try to add this to salsa-ci.yml:
>
> variables:
>   LC_ALL: C.UTF-8
>   LANG: C.UTF-8
>
> It is possible, that you still need to install locales-all or need some
> encoding.
I've seen this happening for a couple of packages more.
Does this mean, we need to do the same for all the packages?
Because, sbuild passes without any complains but CI doesn't :/


Best,
Utkarsh



signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ruby-premailer build failure in salsa ci

Antonio Terceiro-3
On Thu, Aug 15, 2019 at 02:04:37PM +0530, Utkarsh Gupta wrote:

> Hey,
>
> On 15/08/19 8:20 am, Daniel Leidert wrote:
> > Am Mittwoch, den 14.08.2019, 21:45 +0200 schrieb Daniel Leidert:
> >> Am Mittwoch, den 14.08.2019, 22:21 +0500 schrieb Pirate Praveen:
> >>> It fails with error,
> >>>
> >>> Encoding::InvalidByteSequenceError: "\xE2" on US-ASCII
> >>>
> >>> full log https://salsa.debian.org/ruby-team/ruby-premailer/-/jobs/276596
> >>>
> >>> Though it built fine in sbuild. I think salsa ci should use sbuild or same
> >>> settings as sbuild.
> >> Can you try and install locales-all too? This helped me with a similar issue.
> > I now have a similar issue with ruby-jekyll-feed enabling the tests. The tests
> > succeed, if LC_ALL/LANG are set to C.UTF-8, but they fail with the default,
> > which is 'C'. You can try to add this to salsa-ci.yml:
> >
> > variables:
> >   LC_ALL: C.UTF-8
> >   LANG: C.UTF-8
> >
> > It is possible, that you still need to install locales-all or need some
> > encoding.
>
> I've seen this happening for a couple of packages more.
> Does this mean, we need to do the same for all the packages?
> Because, sbuild passes without any complains but CI doesn't :/
FWIW I raised this issue on #salsaci yesterday, and there is sympathy
for using sbuild for doing the builds. So I don't think we should "just"
set UTF-8 on all of out packages, and instead fix the root cause of the
issue in the salsa-ci pipeline. maybe switching to sbuild, or maybe just
setting the locale to UTF-8 there as well (probably easier).

they probably take patches. :-)

signature.asc (849 bytes) Download Attachment